Improving vertx-heroku example#340
Open
Tobias-Doerner wants to merge 1 commit intovert-x3:masterfrom
Tobias-Doerner:heroku-example-improvements
Open
Improving vertx-heroku example#340Tobias-Doerner wants to merge 1 commit intovert-x3:masterfrom Tobias-Doerner:heroku-example-improvements
Tobias-Doerner wants to merge 1 commit intovert-x3:masterfrom
Tobias-Doerner:heroku-example-improvements
Conversation
Updated version of the heroku-maven-plugin. Using the vertx config retriever to retrieve the system properties and the config vars defined in heroku application settings.
Contributor
|
what is using sun.misc.BASE64Encoder ? |
Author
|
heroku-maven-plugin version 0.5.6 is using sun.misc.BASE64Encoder, look here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current vertx-heroku example is not compiling with Java 10. sun.misc.BASE64Encoder is missing updating the heroku-maven-plugin to the current version fixes that issue. I also would like to propose to use the vertx config retriever for fetching the system properties and the config vars defined in heroku's application settings.