Open
Conversation
Need to write your IP address in the box.
ex) options.setClusterHost("192.168.0.55");
tsegismont
requested changes
Sep 21, 2017
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
@pipy201 thanks for the PR! A few changes are needed
| void init() throws ExecutionException, InterruptedException { | ||
| VertxOptions options = new VertxOptions() | ||
| .setClusterManager(new HazelcastClusterManager(hazelcastInstance)); | ||
| VertxOptions options = new VertxOptions() |
Member
There was a problem hiding this comment.
Please update your IDE config to use 2 spaces instead of 4.
| .setClusterManager(new HazelcastClusterManager(hazelcastInstance)); | ||
| VertxOptions options = new VertxOptions() | ||
| .setClusterManager(new HazelcastClusterManager(hazelcastInstance)) | ||
| .setClustered(true) |
| VertxOptions options = new VertxOptions() | ||
| .setClusterManager(new HazelcastClusterManager(hazelcastInstance)) | ||
| .setClustered(true) | ||
| .setHAEnabled(true) |
| .setClusterManager(new HazelcastClusterManager(hazelcastInstance)) | ||
| .setClustered(true) | ||
| .setHAEnabled(true) | ||
| .setClusterHost("192.168.0.67");// Write your ip address numeric form |
Member
There was a problem hiding this comment.
You can't do this otherwise no one can run the examples without modifying source. You could introduce a Spring config property for cluster host. If not set, setClusterHost would not be called
Member
|
@pipy201 any news on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to write your IP address.
ex) options.setClusterHost("192.168.0.55");