fix: close temp file before rename in sidecar StoreAttribute#2046
Merged
benmcclelland merged 1 commit intomainfrom Apr 15, 2026
Merged
fix: close temp file before rename in sidecar StoreAttribute#2046benmcclelland merged 1 commit intomainfrom
benmcclelland merged 1 commit intomainfrom
Conversation
On Windows, a file apparently cannot be renamed while an open handle to it exists. The previous code used defer tempfile.Close(), which meant the handle was still open when os.Rename was called, producing: failed to rename temporary file: The process cannot access the file because it is being used by another process. Fix by closing the file explicitly before the rename. Fixes #2021
niksis02
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a file apparently cannot be renamed while an open handle to it exists.
The previous code used defer tempfile.Close(), which meant the handle was still open when os.Rename was called, producing:
failed to rename temporary file: The process cannot access
the file because it is being used by another process.
Fix by closing the file explicitly before the rename.
Fixes #2021