Skip to content

Fix calls to removed V8 External API#50

Closed
Nidrax wants to merge 1 commit into
trunkfrom
nidrax/fix-v8-deprecated-external-calls
Closed

Fix calls to removed V8 External API#50
Nidrax wants to merge 1 commit into
trunkfrom
nidrax/fix-v8-deprecated-external-calls

Conversation

@Nidrax
Copy link
Copy Markdown
Member

@Nidrax Nidrax commented May 28, 2026

As per https://chromium-review.googlesource.com/c/v8/v8/+/7562476
The External::New and External::Value now require explicit ExternalPointerTypeTag argument.
This change fixes outdated calls to now defunct API.

Closes #49

@Nidrax Nidrax force-pushed the nidrax/fix-v8-deprecated-external-calls branch 2 times, most recently from 4b88ff4 to d9b425c Compare May 28, 2026 09:06
As per https://chromium-review.googlesource.com/c/v8/v8/+/7562476
The External::New and External::Value now require
explicit ExternalPointerTypeTag argument.
This change fixes outdated calls to now defunct API.

Closes #49
@Nidrax Nidrax force-pushed the nidrax/fix-v8-deprecated-external-calls branch from d9b425c to 6fd976f Compare May 28, 2026 09:12
@Nidrax Nidrax added the ⛔won't fix This will not be worked on label May 28, 2026
@Nidrax
Copy link
Copy Markdown
Member Author

Nidrax commented May 28, 2026

Can't be merged due to incompatible library versions between macOS, Msys2 and Ubuntu used for GitHub workflows and the dylibs signage breaking on macOS. Will be replaced by #51
In the future either the V8 lib versions will be aligned or will have to be fixed by working around the OS compilation flags.
In the long run we might want to develop our own scripting API with smaller footprint either based on Python or Lua, probably drop V8 completely and either use Duktape only or replace it with some alternative, slower but more lightweight JS engine library for optional backawrds LS scripts compatibility.

@Nidrax Nidrax closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⛔won't fix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken mac build due to changes in V8 headers

1 participant