Fix calls to removed V8 External API#50
Closed
Nidrax wants to merge 1 commit into
Closed
Conversation
4b88ff4 to
d9b425c
Compare
As per https://chromium-review.googlesource.com/c/v8/v8/+/7562476 The External::New and External::Value now require explicit ExternalPointerTypeTag argument. This change fixes outdated calls to now defunct API. Closes #49
d9b425c to
6fd976f
Compare
Member
Author
|
Can't be merged due to incompatible library versions between macOS, Msys2 and Ubuntu used for GitHub workflows and the dylibs signage breaking on macOS. Will be replaced by #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://chromium-review.googlesource.com/c/v8/v8/+/7562476
The External::New and External::Value now require explicit ExternalPointerTypeTag argument.
This change fixes outdated calls to now defunct API.
Closes #49