fix(vm): restore hint bar on wizard's self-prompting pickers#51
Merged
Conversation
The vm create wizard's storage, ssh-keys, and startup-script steps prompt
inside their Loaders via direct prompter.Select/MultiSelect calls. In
per-prompt mode the composite program (which draws the layout's hint bar)
isn't running while a Loader executes, so these pickers rendered without
the hint legend — the SSH multi-select looked like a plain list, and
pressing enter without space-toggling threw "at least 1 selection
required" with no visible cue that space toggles.
Pass WithShowHints / WithMultiSelectShowHints to all seven such calls (the
three step prompts plus the add-key, pick-pub-file, add-script, and
attach-volume sub-flows).
Also trim the hand-rolled "(Ctrl+D to finish)" from the two startup-script
editor labels; verdagostack's editor now renders the standard
"(ctrl+d to submit, esc to cancel)" affordance by default.
Bump verdagostack v1.4.1 -> v1.4.2 for the improved multiselect
min-selection error message ("... — press space to select") and the
editor hint/summary override hooks.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
vm createwizard's storage, ssh-keys, and startup-script steps prompt inside their Loaders via directprompter.Select/prompter.MultiSelectcalls. In per-prompt mode the wizard composite (which draws the layout's hint bar) isn't running while a Loader executes, so these pickers rendered without the hint legend.The SSH multi-select was the worst case: it looked like a plain list, and pressing
enterwithoutspace-toggling threw✗ at least 1 selections requiredwith no visible cue thatspacetoggles.Changes
storage,ssh-keys,startup-script) plus theadd-key,pick-pub-file,add-script, andattach-volumesub-flows — viaWithShowHints/WithMultiSelectShowHints.(Ctrl+D to finish)from the two startup-script editor labels; verdagostack's editor now renders the standard(ctrl+d to submit, esc to cancel)affordance by default (and surfaces theesc to cancelcue the old label omitted).v1.4.1→v1.4.2, which brings the improved multiselect min-selection error message (… — press space to select) and the editor hint/summary override hooks.Testing
make build✅make test(unit tests +golangci-lint) ✅ — exit 0, no failures, no lint hitsctrl+dsubmit,esccancel, default hint) is intact against v1.4.2; verdagostack editor tests pass.vm createSSH step: hint bar present, improved error message shown.Notes
WithMultiSelectCursor(to highlight a freshly created SSH key after add) did not land in v1.4.2 — that highlight enhancement is deferred to a follow-up once the option exists in verdagostack.🤖 Generated with Claude Code