[don't merge] Run CI for #455 #614
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/workflow-cfg-extractor
…up partial generations
…up partial generations
…/workflow-cfg-extractor
I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 8a3f152 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 252a0dd I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: b002d81 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 8e21d56 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 1c45af6 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 68b23e0 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: e5f4cd8 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: d537846 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 0f62431 Signed-off-by: Karthik Kalyanaraman <karthik@scale3labs.com>
…/workflow-cfg-extractor
Single-statement if/while/for/for-of bodies without braces were ignored. Added recursive analysis for non-block bodies and corresponding tests.
Single-statement if/while/for/for-of bodies without braces were ignored. Added recursive analysis for non-block bodies and corresponding tests.
…/workflow-cfg-extractor
I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 6609b39 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: 2484c01 I, Karthik Kalyanaraman <karthik@scale3labs.com>, hereby add my Signed-off-by to this commit: a0363a1 Signed-off-by: Karthik Kalyanaraman <karthik@scale3labs.com>
* main: [web] Add actions for waking up workflow from sleep and re-enqueue runs for debugging (#582) Override timeout functions in workflow VM context to throw helpful errors (#505) [docs] bump @ai/react version to stop schema validation errors (#606) Update README.md (#601) Version Packages (beta) (#605) CVE-2025-55184 changeset (#604) CVE-2025-55184 (#603) Version Packages (beta) (#589)
🦋 Changeset detectedLatest commit: e5a79b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (2 failed)hono (1 failed):
nextjs-webpack (1 failed):
💻 Local Development (1 failed)vite-stable (1 failed):
🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
❌ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Signed-off-by: Karthik Kalyanaraman <karthik@scale3labs.com>
Signed-off-by: Karthik Kalyanaraman <karthik@scale3labs.com>
Signed-off-by: Karthik Kalyanaraman <karthik@scale3labs.com>
…/workflow-cfg-extractor
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+58
to
+60
| 'app/.well-known/workflow/v1/manifest.json', | ||
| 'src/app/.well-known/workflow/v1/manifest.json', | ||
| '.well-known/workflow/v1/manifest.json', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'app/.well-known/workflow/v1/manifest.json', | |
| 'src/app/.well-known/workflow/v1/manifest.json', | |
| '.well-known/workflow/v1/manifest.json', | |
| // Next.js | |
| 'app/.well-known/workflow/v1/manifest.json', | |
| 'src/app/.well-known/workflow/v1/manifest.json', | |
| '.well-known/workflow/v1/manifest.json', | |
| // SvelteKit | |
| 'src/routes/.well-known/workflow/v1/manifest.json', | |
| 'routes/.well-known/workflow/v1/manifest.json', | |
| // Astro | |
| 'src/pages/.well-known/workflow/v1/manifest.json', | |
| // Nitro-based frameworks (Nuxt, Vite, Hono, Express) | |
| 'node_modules/.nitro/workflow/manifest.json', |
The manifest path detection only includes paths for Next.js applications, missing support for SvelteKit and Nitro-based frameworks (Nuxt, Vite, Hono, Express). This causes the web UI to fail loading workflow graphs for these frameworks.
View Details
Analysis
Missing manifest path detection for SvelteKit, Astro, and Nitro-based frameworks
What fails: The findManifestPath() function in packages/cli/src/lib/inspect/env.ts only checks Next.js manifest paths (app/.well-known/workflow/v1/manifest.json, src/app/.well-known/workflow/v1/manifest.json, .well-known/workflow/v1/manifest.json), causing it to fail finding manifests generated by SvelteKit, Astro, and Nitro-based frameworks (Nuxt, Vite, Hono, Express). This prevents the web UI workflows graph feature from working for these frameworks.
How to reproduce:
- Create a SvelteKit app with workflows and run the builder - manifest generates at
src/routes/.well-known/workflow/v1/manifest.json - Create a Nuxt/Vite/Hono/Express app with workflows and run the builder - manifest generates at
node_modules/.nitro/workflow/manifest.json - Create an Astro app with workflows and run the builder - manifest generates at
src/pages/.well-known/workflow/v1/manifest.json - Run CLI commands that call
inferLocalWorldEnvVars()- theWORKFLOW_MANIFEST_PATHenvironment variable remains unset, and logs show "No workflow manifest found"
Result: The web UI workflows graph remains empty for these frameworks because WORKFLOW_MANIFEST_PATH is not set.
Expected: The possibleManifestPaths array should include framework-specific paths so manifests are detected for all supported frameworks, matching the paths documented in packages/core/e2e/manifest.test.ts.
Fix applied: Added missing manifest paths for SvelteKit (src/routes/.well-known/workflow/v1/manifest.json, routes/.well-known/workflow/v1/manifest.json), Astro (src/pages/.well-known/workflow/v1/manifest.json), and Nitro-based frameworks (node_modules/.nitro/workflow/manifest.json) to the possibleManifestPaths array in packages/cli/src/lib/inspect/env.ts:56-64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run's CI for #455