[do not merge] Bump flight-booking-app + nextjs to workflow v5 beta#50
Draft
VaguelySerious wants to merge 1 commit into
Draft
[do not merge] Bump flight-booking-app + nextjs to workflow v5 beta#50VaguelySerious wants to merge 1 commit into
VaguelySerious wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
VaguelySerious
changed the title
VaguelySerious
changed the title
Move both examples to the published v5 pre-release on npm: - flight-booking-app: workflow@5.0.0-beta.15, @workflow/ai@5.0.0-beta.9, @workflow/world-postgres@5.0.0-beta.14 - nextjs: workflow@5.0.0-beta.15 flight-booking-app also needs a v5 migration fix: `getWorld()` is now async (returns `Promise<World>`), so `instrumentation.ts` must await it before calling `world.start?.()` — otherwise the world worker silently never starts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
VaguelySerious
force-pushed
the
peter/examples-prerelease-tarball
branch
from
cb5c231 to
e20c833
Compare
VaguelySerious
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
VaguelySerious
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the workflow deps in flight-booking-app and nextjs to the published v5.0.0-beta pre-release on npm.
flight-booking-app:workflow@5.0.0-beta.15,@workflow/ai@5.0.0-beta.9,@workflow/world-postgres@5.0.0-beta.14nextjs:workflow@5.0.0-beta.15(
@workflow/aiand@workflow/world-postgreshave no.15published;.9and.14are their latest betas from the same release line.)v5 migration finding
getWorld()is now async in v5 (() => Promise<World>). The flight-booking-appinstrumentation.tscalledgetWorld().start?.(), which fails the type check and — more importantly — would silently no-op at runtime (.startisundefinedon a Promise), so the world worker would never start. Fixed by awaiting:This is the only example using the optional async-world bootstrap, so it's the only one affected.
Local testing
pnpm build✓;pnpm dev+curl -X POST /api/signupstarted a run and both steps (create user, send welcome email) executed via the flow route ✓pnpm build✓ (after the instrumentation fix);pnpm devboots, homepage 200, "Initializing workflow World" logs ✓ (LLM chat path not exercised — no AI Gateway key configured locally)🤖 Generated with Claude Code