Open
Conversation
Add specific error classes to help downstream consumers to do conditional error handling and bring structure to our generic APIError class.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a structured sandbox-specific error hierarchy so downstream consumers can perform conditional error handling (e.g., auth vs rate-limit vs server failures) while preserving the existing APIError surface.
Changes:
- Add
SandboxErroras a base class and introduce sandbox-specificAPIErrorsubclasses (SandboxAuthError,SandboxPermissionError,SandboxRateLimitError,SandboxServerError). - Update
SandboxRequestClientto classify non-2xx HTTP responses into the new typed errors (includingretry_aftersupport for 429s). - Re-export the new error types from both internal and public sandbox modules and expand unit/integration test coverage.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_sandbox_errors.py | Adds unit tests covering public re-exports and status-code-based error classification. |
| tests/integration/test_sandbox_streaming_errors.py | Updates streaming integration tests to assert the new typed errors for non-2xx responses. |
| src/vercel/sandbox/init.py | Re-exports the new public error hierarchy from the sandbox package. |
| src/vercel/_internal/sandbox/errors.py | Defines the new sandbox error hierarchy and retry_after normalization for rate limits. |
| src/vercel/_internal/sandbox/core.py | Implements status-code-to-exception mapping and raises typed sandbox errors from the request layer. |
| src/vercel/_internal/sandbox/init.py | Re-exports internal error types to support public imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add specific error classes to help downstream consumers to do conditional error handling and bring structure to our generic APIError class.