Properly support UpdateClass on generic types#93
Merged
Conversation
msullivan
approved these changes
Feb 11, 2026
typemap/type_eval/_eval_operators.py
Outdated
|
|
||
| def _get_update_class_members( | ||
| cls: type, base: type, ctx: typing.Any | ||
| box: _apply_generic.Boxed, base: type, ctx: EvalContext |
Collaborator
There was a problem hiding this comment.
We should probably pass a Boxed for base instead. We have one, but we call alias_type() on it, and then have to extract a bunch of info that was more easily available in the `Boxed.
typemap/type_eval/_eval_operators.py
Outdated
| ret_annotation, substitution | ||
| ) | ||
|
|
||
| # __init_subclass__ hooks may have annotations that reference the |
Collaborator
There was a problem hiding this comment.
I'm not certain I follow the case here?
The modified version still makes it into the cache eventually, right?
Contributor
Author
There was a problem hiding this comment.
I was getting confused with what was actually going into the cache. Removed this weirdness.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dnwpark
force-pushed
the
updateclass-generic-base
branch
from
26b5027 to
da650e4
Compare
msullivan
reviewed
Feb 11, 2026
Comment on lines
+223
to
+225
| if (base_args := boxed_base.args.values()) and ( | ||
| origin_params := getattr(base_origin, '__type_params__', None) | ||
| ): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A series of dubious fixes to support generic base and derived types which have
__init_subclass__ -> UpdateClass