Build GenericCallables when we can't evaluate a method's params#90
Merged
Build GenericCallables when we can't evaluate a method's params#90
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dnwpark
approved these changes
Feb 9, 2026
| sig = inspect.signature(root) | ||
| # XXX: __type_params__!!! | ||
|
|
||
| def _function_type_from_sig(sig, func, *, receiver_type): |
Contributor
There was a problem hiding this comment.
could maybe replace func with func_type
Collaborator
Author
There was a problem hiding this comment.
It's not, though; it's the actual function?
Oh, or did you mean pass in type(func) instead?
msullivan
force-pushed
the
update-class
branch
from
122c640 to
3f31f0c
Compare
msullivan
force-pushed
the
generic-callable
branch
from
cfc421e to
f6745ce
Compare
The lambda we stick into the GenericCallable will actually go evaluate the type annotations, then produce a Callable.
msullivan
force-pushed
the
generic-callable
branch
from
f6745ce to
a3cb55c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lambda we stick into the GenericCallable will actually go evaluate
the type annotations, then produce a Callable.