Make __init_subclass__ work with nontrivial RHSes#89
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
msullivan
force-pushed
the
update-class
branch
from
8afdb8b to
122c640
Compare
Basically the idea is to evaluate it with the type variable substituted in. I had to rework the caching for boxes to prevent infinite recursion. It's still a TODO to properly report out GenericCallables for methods with nontrivial computation at the top level, but the basic idea is to *try* to get the annotation and raise a StuckException if we would need to use an operator on a variable while evaluating a Bool or Iter. Then if the exception got raised, we will produce a GenericCallable.
msullivan
force-pushed
the
update-class
branch
from
122c640 to
3f31f0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the idea is to evaluate it with the type variable
substituted in. I had to rework the caching for boxes to prevent
infinite recursion.
It's still a TODO to properly report out GenericCallables for methods
with nontrivial computation at the top level, but the basic idea is to
try to get the annotation and raise a StuckException if we would
need to use an operator on a variable while evaluating a Bool or
Iter. Then if the exception got raised, we will produce a
GenericCallable.