Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
msullivan
reviewed
Feb 5, 2026
Comment on lines
589
to
+593
| if root.__type_params__: | ||
| f = GenericCallable[tuple[*root.__type_params__], f] | ||
| # Must store a lambda that performs type variable substitution | ||
| type_params = root.__type_params__ | ||
| callable_lambda = _create_generic_callable_lambda(f, type_params) | ||
| f = GenericCallable[tuple[*type_params], callable_lambda] |
Collaborator
There was a problem hiding this comment.
I think for this to work right in the cases where the annotations do nontrivial computation on the params, it needs to go first, and then the whole rest of everything needs to be in the lambda?
msullivan
approved these changes
Feb 5, 2026
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
This works and I think maintains parity with what we have now, but it'll need a bit of restructuring to fully solve the problems we want to solve with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenericCallableshould now be used likeGenericCallable[tuple[T, U], lambda T, U: Callable[[T, U], tuple[T, U]]]The
__class_getitem__method is used to generate a_GenericCallableGenericAlias.