Closed
Conversation
msullivan
reviewed
Jan 16, 2026
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
Is this worth doing fully like this?
We could do eval_call(C.invoke, C[int], 1) instead and get the same outcome without the method binding mechanism, right?
(Oh, though that would still require some different weird type var handling?)
msullivan
reviewed
Jan 16, 2026
| # generic class, generic method | ||
| X = TypeVar("X") | ||
|
|
||
| class C(Generic[X]): |
Collaborator
There was a problem hiding this comment.
Does the generic class syntax work? (class C[X]:)
Contributor
Author
There was a problem hiding this comment.
Yes, I just added tests to confirm this.
Contributor
Author
|
This PR extends the eval_call while continuing the assumption that all parameters are actual runtime values. The other PR is the one where I am trying to check things completely during static check time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
eval_callon bound member functions.