Conversation
|
We already do support positional only params, by way of leaving the name empty. It wouldn't be terrible to do it via a qualifier though instead, I guess? |
|
I also just pushed (...without a PR) fb16d9d, which adds abbreviations for all the Param types |
dnwpark
force-pushed
the
positional-params
branch
from
4c8b9c4 to
9500c4e
Compare
typemap/type_eval/_eval_operators.py
Outdated
| if tp_head is staticmethod: | ||
| return typing.get_args(evaled) |
There was a problem hiding this comment.
This certainly does not strike me as right
There was a problem hiding this comment.
Ok this was very not right, but was me ham fisting my way through staticmethod and classmethod not being subtypes of Callable.
| class CMethod: | ||
| @classmethod | ||
| def cbase2(_arg0: type[tests.test_type_dir.CMethod], _arg1: int, /, a: bool | None) -> int: ... | ||
| def cbase2(cls: type[tests.test_type_dir.CMethod], lol: int, /, a: bool | None) -> int: ... |
There was a problem hiding this comment.
Oh is part of the point here to be able to preserve these names?
There was a problem hiding this comment.
Yeah, since we have them anyways, it's weird to just throw them away
There was a problem hiding this comment.
It's not really part of the type anymore, though.
(Although arguably we keep other things like that...)
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
Need to update PosParam/PosNamedParam abbrevs also
dnwpark
force-pushed
the
positional-params
branch
from
9500c4e to
e368e57
Compare
|
Ok I looked into the weirdness and it's because |
2 participants
No description provided.