Support creating methods nicely in generated classes#28
Merged
Conversation
msullivan
force-pushed
the
func-syntax
branch
from
e2e94a8 to
932bf7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do this we convert our Callable+Param types into methods. The main
reason for this is because it seems to be the expected thing, though
maybe we'd be better off keeping them as methods?
This lets us implement flatten_type fully in terms of
NewProtocol+Members, no special work needed, though!I also added GenericCallable, since pulling that off required being
able to represent type params. I am suuuuper unsure about that one,
though.