Fix type eval if params are not in alphabetical order.#23
Merged
Conversation
msullivan
approved these changes
Jan 9, 2026
typemap/type_eval/_eval_typing.py
Outdated
Comment on lines
+301
to
+302
| # obj.__args__ matches the declared parameter order, but args are expected | ||
| # to be in alphabetical order. |
Collaborator
There was a problem hiding this comment.
Sorry, expected by what to be in alphabetical order? By co_freevars? Make that clear in the comment.
Though actually it's I guess not technically expected in alphabetical order. It's expected in the order co_freevars lists. Which probably happens to be alphabetical.
(I was confused for a minute because you were talking about alphabetical order but there wasn't any sort call)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
type X[B, A] = A