Use a name derived from the context to name NewProtocols#2
Merged
Conversation
msullivan
changed the title
1st1
reviewed
Oct 8, 2025
typemap/typing.py
Outdated
| name = "NewProtocol" | ||
|
|
||
| # If the type evaluation context | ||
| ctx = type_eval._current_context.get() |
Member
There was a problem hiding this comment.
ctx must always be set; I recommend we add a function to get the current context that will always return a non-optional context ref
Collaborator
Author
There was a problem hiding this comment.
Roger, and we are OK with NewProtocolMeta only getting called from our evaluator?
Collaborator
Author
There was a problem hiding this comment.
Ha, looks like we aren't setting a context during eval_call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.