Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
msullivan
reviewed
Feb 26, 2026
| of ``user`` that were requested; one of the requested elements, | ||
| ``posts``, is a "relation" referencing another model; it has *all* of | ||
| its properties fetched but not its relations. | ||
| Here, the output type is an intersection of the existing information |
Collaborator
There was a problem hiding this comment.
I don't feel super strongly, but I was avoiding the word intersection because it's a technical term and we aren't adding intersection types
| the database ``user`` table) and the type of the argument to | ||
| the ``findMany`` method. It returns an array of objects containing | ||
| the properties of ``user`` that were explicitly requested; | ||
| where ``posts`` is a "relation" referencing another type. |
Collaborator
There was a problem hiding this comment.
Not worth keeping the explanation that posts only includes properties?
pep.rst
Outdated
Comment on lines
+143
to
+144
| Even further, the IDE would offer code completion for | ||
| all arguments of the ``db.select()`` call, recursively. |
Collaborator
There was a problem hiding this comment.
I would probably soften to "an IDE could", since we aren't really making a requirement of that?
But also, with the way the query builder example is implemented right now, I think this is not true. There are ways of doing it where it would work, though; should I look into updating the example?
msullivan
reviewed
Feb 26, 2026
msullivan
reviewed
Feb 26, 2026
msullivan
reviewed
Feb 26, 2026
msullivan
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.