[turbopack] Use bail! instead of panic! for duplicate module ident error#91636
Merged
[turbopack] Use bail! instead of panic! for duplicate module ident error#91636
Conversation
Converts the hard process crash into a propagatable anyhow error, consistent with the rest of the error handling in this function and module. Co-Authored-By: Claude <noreply@anthropic.com>
nextjs-bot
added
created-by: Turbopack team
Collaborator
Tests Passed |
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
Merging this PR will not alter performance
Comparing 
Footnotes
|
mischnic
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In
turbopack/crates/turbopack-core/src/module_graph/mod.rs, the#[cfg(debug_assertions)]duplicate module ident detection block insideSingleModuleGraph::new_innercalledpanic!when duplicates were found.Why?
panic!terminates the process hard, bypassing the normal error-handling chain. The enclosing functionnew_inneralready returnsanyhow::Result<Vc<Self>>, andbail!is already imported and used elsewhere in the same file. Usingbail!converts this into a propagatable error, consistent with the rest of the error-handling idioms in the module.How?
Single-line change: replace
panic!(...)withbail!(...)at the duplicate module detection site. No new imports needed —bail!was already in scope viause anyhow::{Context, Result, bail};.