Skip to content

Handle encoded params further#91627

Draft
ijjk wants to merge 7 commits intocanaryfrom
ijjk/more-encoding-normalizing
Draft

Handle encoded params further#91627
ijjk wants to merge 7 commits intocanaryfrom
ijjk/more-encoding-normalizing

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Mar 19, 2026

Continues #91603 applying the encoding normalization further and narrows in a better regression test separate of root params and specific to vary params flag.

@nextjs-bot nextjs-bot added created-by: Next.js team PRs by the Next.js team. tests labels Mar 19, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 19, 2026

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 484 MB 484 MB 🔴 +143 kB (+0%) █████
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 457ms ▁▁█▁▁
Cold (Ready in log) 455ms 461ms ▁▁▇▁▁
Cold (First Request) 905ms 880ms ▂▁█▂▁
Warm (Listen) 456ms 456ms ▁▁█▁▁
Warm (Ready in log) 457ms 455ms ▁▁█▁▁
Warm (First Request) 367ms 361ms ▁▁█▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms █▁▁▁█
Cold (Ready in log) 438ms 438ms ▁▁▁▁▁
Cold (First Request) 1.950s 1.936s ████▃
Warm (Listen) 455ms 456ms ▅▅▅▅▁
Warm (Ready in log) 438ms 439ms ▁▁▁▁▁
Warm (First Request) 1.961s 1.958s ▇██▇▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.191s 4.156s ▁▁█▁▁
Cached Build 4.226s 4.215s ▁▁█▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.277s 14.390s ▄▄▄▄▃
Cached Build 14.398s 14.439s ▅▅▄▄▄
node_modules Size 484 MB 484 MB 🔴 +143 kB (+0%) █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
0-a3rz67ec0it.js gzip 157 B N/A -
0~lwfcrlb4v_9.css gzip 115 B 115 B
00h0nz7r436~l.js gzip 13.3 kB N/A -
00ivb_iunbucu.js gzip 13 kB N/A -
02ku7edzc_wf7.js gzip 450 B N/A -
03~yq9q893hmn.js gzip 39.4 kB 39.4 kB
037mxw~u2_79t.js gzip 154 B N/A -
08wow2p6zxy.b.js gzip 7.61 kB N/A -
092lcb3fqrrf9.js gzip 8.52 kB N/A -
0aj~xs1l1g8tg.js gzip 8.53 kB N/A -
0gob4q88vgv3u.js gzip 156 B N/A -
0h35gmp9u328z.js gzip 8.54 kB N/A -
0h6fkavebp.iz.js gzip 8.47 kB N/A -
0hcg0snee_9wv.js gzip 156 B N/A -
0i8jiw50w3l38.js gzip 154 B N/A -
0ino_yf1k3h6k.js gzip 10.4 kB N/A -
0kkeoe2n.293z.js gzip 160 B N/A -
0l~j-k_rjuult.js gzip 70.8 kB N/A -
0mc16gv2x1bet.js gzip 13.7 kB N/A -
0mcszt6vwd60_.js gzip 154 B N/A -
0mgzv7x.0y719.js gzip 169 B N/A -
0moy~uao4dl.m.js gzip 9.19 kB N/A -
0n5ln2l5jgra~.js gzip 152 B N/A -
0ovzdapbcjgc7.js gzip 65.7 kB N/A -
0p2fwrxw124by.js gzip 160 B N/A -
0q50rtpusjy90.js gzip 2.28 kB N/A -
0smgy2grrrlka.js gzip 8.58 kB N/A -
0t1dzhdfh0txh.js gzip 215 B 215 B
0vt7pofxnk8in.js gzip 10.1 kB N/A -
0zid7o0-vupvp.js gzip 225 B N/A -
1030wmumq.hbq.js gzip 156 B N/A -
11yo3xfd6b147.js gzip 12.9 kB N/A -
13.84hqxl_1p7.js gzip 9.76 kB N/A -
13ddjl2tc8beg.js gzip 153 B N/A -
14_hwphcs58-s.js gzip 48.6 kB N/A -
1554wr-t7p6z-.js gzip 8.55 kB N/A -
15pd.z8aymtma.js gzip 155 B N/A -
15tjst79~qy3_.js gzip 1.46 kB N/A -
15z_v00ne4ud0.js gzip 8.47 kB N/A -
17d_m3p4j9w6r.js gzip 5.62 kB N/A -
17yu~3yiu7d2m.js gzip 8.52 kB N/A -
turbopack-0-..rr~~.js gzip 4.15 kB N/A -
turbopack-01..zoj7.js gzip 4.16 kB N/A -
turbopack-01..cl9..js gzip 4.16 kB N/A -
turbopack-0d..r9ub.js gzip 4.15 kB N/A -
turbopack-0f..1w4v.js gzip 4.15 kB N/A -
turbopack-0g..5lrl.js gzip 4.16 kB N/A -
turbopack-0l..d~my.js gzip 4.14 kB N/A -
turbopack-0l..aco3.js gzip 4.16 kB N/A -
turbopack-0p..4qy0.js gzip 4.17 kB N/A -
turbopack-0p..y0cg.js gzip 4.16 kB N/A -
turbopack-0q..cwm4.js gzip 4.15 kB N/A -
turbopack-0z..uyvd.js gzip 4.16 kB N/A -
turbopack-10..ov9~.js gzip 4.16 kB N/A -
turbopack-15..lg62.js gzip 4.16 kB N/A -
0_.49f9yku.5j.js gzip N/A 48.6 kB -
01fz~yk-xpt_j.js gzip N/A 155 B -
03q~t68gnhli5.js gzip N/A 151 B -
03t__~.5lvgeu.js gzip N/A 5.62 kB -
04d6ll75jqx3r.js gzip N/A 9.19 kB -
04ohz21fsta_x.js gzip N/A 155 B -
0583exyh-yhc7.js gzip N/A 9.76 kB -
072lv63r8dcz~.js gzip N/A 8.58 kB -
075t9dxgbf0m8.js gzip N/A 13.7 kB -
0aayvzj0bc0sv.js gzip N/A 65.7 kB -
0ar1~bwpezfgw.js gzip N/A 13.3 kB -
0b8f8fliy73oo.js gzip N/A 156 B -
0bf-.01jgmps6.js gzip N/A 155 B -
0bh~qxl7qejt_.js gzip N/A 156 B -
0c99mq1ez2bke.js gzip N/A 450 B -
0cq-cmde_ws6u.js gzip N/A 8.47 kB -
0ejf9o-j2g.v8.js gzip N/A 161 B -
0fbbsxh94xk-..js gzip N/A 153 B -
0fwf102w10o9~.js gzip N/A 8.52 kB -
0g1-kfhbbj91x.js gzip N/A 153 B -
0gtmn.q_j1v5r.js gzip N/A 10.4 kB -
0h5~v-tahitcf.js gzip N/A 10.1 kB -
0jvqf.i8i3nyb.js gzip N/A 168 B -
0l3rjj4_ye7_a.js gzip N/A 159 B -
0nclq9z6yzzm5.js gzip N/A 1.46 kB -
0nzumcogektg7.js gzip N/A 8.55 kB -
0p5sjual.nuis.js gzip N/A 13 kB -
0p88ggrxiy7bp.js gzip N/A 7.6 kB -
0s.c-cn5eebrx.js gzip N/A 8.47 kB -
0tna7lg6q4zne.js gzip N/A 12.9 kB -
0votdfxr5fb5u.js gzip N/A 2.28 kB -
0ykl9bs_qj.5..js gzip N/A 8.52 kB -
0zfen0tnxp4gh.js gzip N/A 8.55 kB -
101h7adwwavut.js gzip N/A 70.8 kB -
10wkq1h9jzkg..js gzip N/A 225 B -
11bj8iuigzpg6.js gzip N/A 150 B -
11jeywtke9fil.js gzip N/A 154 B -
149ndfh8zfcaz.js gzip N/A 8.53 kB -
turbopack-0~..8_c3.js gzip N/A 4.15 kB -
turbopack-0~..u794.js gzip N/A 4.15 kB -
turbopack-00..vw48.js gzip N/A 4.16 kB -
turbopack-07.._bvj.js gzip N/A 4.14 kB -
turbopack-08..mj...js gzip N/A 4.16 kB -
turbopack-0b..lw-4.js gzip N/A 4.16 kB -
turbopack-0f..y01v.js gzip N/A 4.15 kB -
turbopack-0p..3gzv.js gzip N/A 4.16 kB -
turbopack-0s..kjmy.js gzip N/A 4.17 kB -
turbopack-0y..8oe7.js gzip N/A 4.16 kB -
turbopack-0y..ft~1.js gzip N/A 4.15 kB -
turbopack-10..noez.js gzip N/A 4.15 kB -
turbopack-11..x5rm.js gzip N/A 4.15 kB -
turbopack-17..oaih.js gzip N/A 4.15 kB -
Total 463 kB 463 kB ✅ -24 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 711 B 714 B
Total 711 B 714 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 433 B 426 B 🟢 7 B (-2%)
Total 433 B 426 B ✅ -7 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 60.4 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.7 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 255 B 254 B
main-HASH.js gzip 39.3 kB 39.2 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.7 kB -
9544-HASH.js gzip N/A 61.1 kB -
Total 234 kB 235 kB ⚠️ +674 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.51 kB 2.51 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 269 kB 269 kB
Total 394 kB 394 kB ✅ -82 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 615 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.6 kB 44 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.2 kB 45.6 kB ⚠️ +420 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.28 MB 4.27 MB 🟢 10.9 kB (0%)
index.pack gzip 111 kB 110 kB 🟢 1.41 kB (-1%)
index.pack.old gzip 110 kB 110 kB
Total 4.5 MB 4.49 MB ✅ -12.2 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 333 kB 333 kB
app-page-exp..prod.js gzip 181 kB 181 kB
app-page-tur...dev.js gzip 333 kB 333 kB
app-page-tur..prod.js gzip 181 kB 181 kB
app-page-tur...dev.js gzip 329 kB 330 kB
app-page-tur..prod.js gzip 179 kB 179 kB
app-page.run...dev.js gzip 330 kB 330 kB
app-page.run..prod.js gzip 179 kB 179 kB
app-route-ex...dev.js gzip 76.1 kB 76.3 kB
app-route-ex..prod.js gzip 51.8 kB 51.9 kB
app-route-tu...dev.js gzip 76.1 kB 76.3 kB
app-route-tu..prod.js gzip 51.8 kB 51.9 kB
app-route-tu...dev.js gzip 75.7 kB 75.9 kB
app-route-tu..prod.js gzip 51.6 kB 51.7 kB
app-route.ru...dev.js gzip 75.7 kB 75.9 kB
app-route.ru..prod.js gzip 51.5 kB 51.6 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.4 kB 43.5 kB
pages-api-tu..prod.js gzip 33 kB 33.1 kB
pages-api.ru...dev.js gzip 43.3 kB 43.5 kB
pages-api.ru..prod.js gzip 33 kB 33.1 kB
pages-turbo....dev.js gzip 52.7 kB 52.9 kB
pages-turbo...prod.js gzip 38.6 kB 38.7 kB
pages.runtim...dev.js gzip 52.7 kB 52.9 kB
pages.runtim..prod.js gzip 38.6 kB 38.7 kB
server.runti..prod.js gzip 62.4 kB 62.5 kB
Total 2.95 MB 2.96 MB ⚠️ +3.19 kB
📝 Changed Files (25 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • pages-api-tu..ntime.dev.js
  • pages-api-tu..time.prod.js
  • pages-api.runtime.dev.js
  • pages-api.ru..time.prod.js
  • ... and 5 more
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js

Diff too large to display

app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

pages-api-tu..ntime.dev.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/2e6b4ea2436251abfd00cf67ffcfd42eb2b112c6/next

@vercel vercel deleted a comment from nextjs-bot Mar 19, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 19, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 19, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 19, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 19, 2026
@vercel vercel deleted a comment from nextjs-bot Mar 19, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 19, 2026

Failing test suites

Commit: 2e6b4ea | About building and testing Next.js

pnpm test-start test/e2e/app-dir/app-prefetch/prefetching.test.ts (job)

  • app dir - prefetching > should not unintentionally modify the requested prefetch by escaping the uri encoded query params (DD)
Expand output

● app dir - prefetching › should not unintentionally modify the requested prefetch by escaping the uri encoded query params

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  369 |     expect(
  370 |       await browser.hasElementByCssSelector('#accordion-to-dashboard')
> 371 |     ).toBe(true)
      |       ^
  372 |
  373 |     await browser.waitForIdleNetwork()
  374 |

  at Object.toBe (e2e/app-dir/app-prefetch/prefetching.test.ts:371:7)

pnpm test-dev test/e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts (job)

  • instant-navigation-testing-api > renders runtime-prefetched content instantly during navigation (DD)
Expand output

● instant-navigation-testing-api › renders runtime-prefetched content instantly during navigation

locator.waitFor: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-testid="search-param-value"]') to be visible

  105 |         '[data-testid="search-param-value"]'
  106 |       )
> 107 |       await searchParamValue.waitFor({ state: 'visible' })
      |                              ^
  108 |       expect(await searchParamValue.textContent()).toContain(
  109 |         'myParam: testValue'
  110 |       )

  at waitFor (e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts:107:30)
  at instant (../packages/next-playwright/dist/index.js:50:16)
  at Object.<anonymous> (e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts:99:5)

pnpm test-start test/e2e/app-dir/segment-cache/staleness/segment-cache-per-page-dynamic-stale-time.test.ts (job)

  • segment cache (revalidation) > refetch visible Form components after cache is revalidated (DD)
Expand output

● segment cache (revalidation) › refetch visible Form components after cache is revalidated

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  50 |       }
  51 |
> 52 |       const result = Reflect.apply(target, thisArg, args)
     |                              ^
  53 |       return typeof result === 'function' ? wrapJestTestFn(result) : result
  54 |     },
  55 |     get(target, prop, receiver) {

  at Object.apply (lib/e2e-utils/index.ts:52:30)
  at it (e2e/app-dir/segment-cache/revalidation/segment-cache-revalidation.test.ts:110:3)
  at Object.describe (e2e/app-dir/segment-cache/revalidation/segment-cache-revalidation.test.ts:8:1)

pnpm test-dev test/e2e/app-dir/actions/app-action.test.ts (job)

  • app-dir action handling > should not error when a forwarded action triggers a redirect (node) (DD)
  • app-dir action handling > should work with interception routes (DD)
  • app-dir action handling > fetch actions > should handle redirects to routes that provide an invalid RSC response (DD)
Expand output

● app-dir action handling › should not error when a forwarded action triggers a redirect (node)

page.waitForSelector: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('#other-page') to be visible

  545 |
  546 |     return this.startChain(async () => {
> 547 |       const el = await page.waitForSelector(selector, {
      |                             ^
  548 |         timeout,
  549 |         state,
  550 |       })

  at waitForSelector (lib/browsers/playwright.ts:547:29)
  at e2e/app-dir/actions/app-action.test.ts:958:7
  at Proxy._chain (lib/browsers/playwright.ts:677:23)
  at Proxy._chain (lib/browsers/playwright.ts:658:17)
  at Proxy.startChain (lib/browsers/playwright.ts:546:17)
  at waitForElementByCss (e2e/app-dir/actions/app-action.test.ts:961:10)

● app-dir action handling › fetch actions › should handle redirects to routes that provide an invalid RSC response

expect(received).toContain(expected) // indexOf

Expected substring: "Hello from a pages route"
Received string:    "0.5863643094538424
Client
Server
Client and Server
0
+1+1 (Slow)-1*2
redirect to a pages route
submit
test"

  1331 |
  1332 |       await retry(async () => {
> 1333 |         expect(await browser.elementByCss('body').text()).toContain(
       |                                                           ^
  1334 |           'Hello from a pages route'
  1335 |         )
  1336 |         expect(await browser.url()).toBe(`${next.url}/pages-dir`)

  at toContain (e2e/app-dir/actions/app-action.test.ts:1333:59)
  at retry (lib/next-test-utils.ts:861:14)
  at Object.<anonymous> (e2e/app-dir/actions/app-action.test.ts:1332:7)

● app-dir action handling › should work with interception routes

expect(received).toContain(expected) // indexOf

Expected substring: "interception-routes/test"
Received string:    "http://localhost:34815/interception-routes"

  1606 |     await retry(async () => {
  1607 |       // verify the URL is correct
> 1608 |       expect(await browser.url()).toContain('interception-routes/test')
       |                                   ^
  1609 |       // the intercepted text should appear
  1610 |       expect(await browser.elementById('modal-data').text()).toContain(
  1611 |         'in "modal"'

  at toContain (e2e/app-dir/actions/app-action.test.ts:1608:35)
  at retry (lib/next-test-utils.ts:861:14)
  at Object.<anonymous> (e2e/app-dir/actions/app-action.test.ts:1606:5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants