Remove `experimental.reactOwnerStack` flag by vercel-release-bot · Pull Request #76021 · vercel/next.js

vercel-release-bot · 2025-02-13T19:51:56Z

experimental.reactOwnerStack is now the default.

diff facebook/react@cbbe8666...32b0cad8

React upstream changes

ijjk · 2025-02-13T19:57:15Z

Failing test suites

Commit: c96d83e

pnpm test-dev test/development/app-dir/experimental-lightningcss/experimental-lightningcss.test.ts

experimental-lightningcss with default mode > in dev server > should support css modules
experimental-lightningcss with default mode > in dev server > should support browserslist

Expand output

● experimental-lightningcss with default mode › in dev server › should support css modules

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  252 |   let next: NextInstance | undefined
  253 |   if (!skipped) {
> 254 |     beforeAll(async () => {
      |     ^
  255 |       next = await createNext(options)
  256 |     })
  257 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils/index.ts:254:5)
  at development/app-dir/experimental-lightningcss/experimental-lightningcss.test.ts:25:37
  at describe (development/app-dir/experimental-lightningcss/experimental-lightningcss.test.ts:24:5)
      at Array.forEach (<anonymous>)
  at lib/next-test-utils.ts:1425:56
  at Object.<anonymous> (development/app-dir/experimental-lightningcss/experimental-lightningcss.test.ts:21:34)

● experimental-lightningcss with default mode › in dev server › should support browserslist

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  252 |   let next: NextInstance | undefined
  253 |   if (!skipped) {
> 254 |     beforeAll(async () => {
      |     ^
  255 |       next = await createNext(options)
  256 |     })
  257 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils/index.ts:254:5)
  at development/app-dir/experimental-lightningcss/experimental-lightningcss.test.ts:25:37
  at describe (development/app-dir/experimental-lightningcss/experimental-lightningcss.test.ts:24:5)
      at Array.forEach (<anonymous>)
  at lib/next-test-utils.ts:1425:56
  at Object.<anonymous> (development/app-dir/experimental-lightningcss/experimental-lightningcss.test.ts:21:34)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/socket-io/index.test.js (PPR)

socket-io > should support socket.io without falling back to polling

Expand output

● socket-io › should support socket.io without falling back to polling

TIMED OUT: /hello world/



undefined

  732 |
  733 |   if (hardError) {
> 734 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  735 |   }
  736 |   return false
  737 | }

  at check (lib/next-test-utils.ts:734:11)
  at Object.<anonymous> (e2e/socket-io/index.test.js:31:5)

Read more about building and testing Next.js in contributing.md.

ijjk · 2025-02-13T20:00:32Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
buildDuration	17.6s	16.1s	N/A
buildDurationCached	15.3s	12.6s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	431ms	433ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
5271-HASH.js gzip	55.4 kB	55.2 kB	N/A
6228c9d4-HASH.js gzip	56.9 kB	53 kB	N/A
7048.HASH.js gzip	168 B	168 B	✓
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	244 B	245 B	N/A
main-HASH.js gzip	34.9 kB	34.9 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	✓
Overall change	1.88 kB	1.88 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	193 B	192 B	N/A
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	342 B	342 B	✓
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	264 B	N/A
head-HASH.js gzip	363 B	360 B	N/A
hooks-HASH.js gzip	393 B	390 B	N/A
image-HASH.js gzip	4.59 kB	4.59 kB	N/A
index-HASH.js gzip	268 B	266 B	N/A
link-HASH.js gzip	2.35 kB	2.35 kB	✓
routerDirect..HASH.js gzip	328 B	326 B	N/A
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	325 B	325 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.72 kB	3.72 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
_buildManifest.js gzip	749 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
index.html gzip	523 B	522 B	N/A
link.html gzip	538 B	536 B	N/A
withRouter.html gzip	519 B	517 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	214 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
middleware-b..fest.js gzip	676 B	674 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.6 kB	31.4 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes Overall increase ⚠️

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
app-page-exp...dev.js gzip	395 kB	395 kB	N/A
app-page-exp..prod.js gzip	133 kB	132 kB	N/A
app-page-tur..prod.js gzip	145 kB	145 kB	N/A
app-page-tur..prod.js gzip	141 kB	141 kB	N/A
app-page.run...dev.js gzip	382 kB	384 kB	⚠️ +1.36 kB
app-page.run..prod.js gzip	129 kB	129 kB	N/A
app-route-ex...dev.js gzip	39.4 kB	39.4 kB	✓
app-route-ex..prod.js gzip	25.7 kB	25.7 kB	N/A
app-route-tu..prod.js gzip	25.7 kB	25.7 kB	N/A
app-route-tu..prod.js gzip	25.5 kB	25.5 kB	N/A
app-route.ru...dev.js gzip	41 kB	39.1 kB	N/A
app-route.ru..prod.js gzip	25.5 kB	25.5 kB	N/A
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.72 kB	9.72 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.72 kB	9.72 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	31.6 kB	31.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	61.2 kB	61.2 kB	N/A
Overall change	529 kB	531 kB	⚠️ +1.36 kB

build cache

	vercel/next.js canary	vercel/next.js update/react/19.1.0-canary-32b0cad8-20250213	Change
0.pack gzip	2.12 MB	2.11 MB	N/A
index.pack gzip	77.7 kB	76.1 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 5271-HASH.js

Diff too large to display

Diff for 6228c9d4-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

failed to diff

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

failed to diff

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: c96d83e

vercel · 2025-02-14T16:32:29Z

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

Co-authored-by: Sebastian Sebbie Silbermann <sebastian.silbermann@vercel.com>

vercel-release-bot assigned eps1lon Feb 13, 2025

vercel-release-bot requested a review from eps1lon February 13, 2025 19:51

vercel-release-bot added the type: react-sync label Feb 13, 2025

ijjk added CI approved Approve running CI for fork type: next labels Feb 13, 2025

eps1lon marked this pull request as draft February 13, 2025 20:05

eps1lon force-pushed the update/react/19.1.0-canary-32b0cad8-20250213 branch from b9bd91c to b5efd8d Compare February 13, 2025 21:04

ijjk added the tests label Feb 13, 2025

eps1lon force-pushed the update/react/19.1.0-canary-32b0cad8-20250213 branch 3 times, most recently from 47b3229 to 1eb4b03 Compare February 14, 2025 10:55

eps1lon approved these changes Feb 14, 2025

View reviewed changes

vercel-release-bot added 6 commits February 14, 2025 13:28

Update react@experimental

93fa12b

Update react

fd7a4c4

Updated peer dependency references in apps

6a3955f

Updated peer dependency references in libraries

8cff4d8

Update lockfile

89f6c8c

ncc-compiled

82a453a

eps1lon force-pushed the update/react/19.1.0-canary-32b0cad8-20250213 branch 3 times, most recently from 998a309 to 7aa5759 Compare February 14, 2025 13:54

eps1lon added the run-react-18-tests label Feb 14, 2025

eps1lon added 2 commits February 14, 2025 16:17

Disable flaky test

66b00bb

Remove experimental.reactOwnerStack

c96d83e

eps1lon force-pushed the update/react/19.1.0-canary-32b0cad8-20250213 branch from 7aa5759 to c96d83e Compare February 14, 2025 15:18

eps1lon changed the title ~~Upgrade React from cbbe8666-20250213 to 32b0cad8-20250213~~ Remove experimental.reactOwnerStack flag Feb 14, 2025

eps1lon marked this pull request as ready for review February 14, 2025 16:32

eps1lon enabled auto-merge (squash) February 14, 2025 16:32

eps1lon disabled auto-merge February 14, 2025 16:58

eps1lon merged commit 07634b2 into canary Feb 14, 2025

eps1lon deleted the update/react/19.1.0-canary-32b0cad8-20250213 branch February 14, 2025 16:58

devjiwonchoi pushed a commit that referenced this pull request Feb 14, 2025

Remove experimental.reactOwnerStack flag (#76021)

8d03bbb

Co-authored-by: Sebastian Sebbie Silbermann <sebastian.silbermann@vercel.com>

eps1lon mentioned this pull request Feb 17, 2025

Cleanup experimental.reactOwnerStack #76123

Merged

github-actions bot added the locked label Mar 1, 2025

github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `experimental.reactOwnerStack` flag#76021

Remove `experimental.reactOwnerStack` flag#76021
eps1lon merged 8 commits intocanaryfrom
update/react/19.1.0-canary-32b0cad8-20250213

vercel-release-bot commented Feb 13, 2025 •

edited by eps1lon

Loading

Uh oh!

ijjk commented Feb 13, 2025 •

edited

Loading

Uh oh!

ijjk commented Feb 13, 2025 •

edited

Loading

Uh oh!

vercel bot commented Feb 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vercel-release-bot commented Feb 13, 2025 • edited by eps1lon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijjk commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing test suites

Uh oh!

ijjk commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

Uh oh!

vercel bot commented Feb 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel-release-bot commented Feb 13, 2025 •

edited by eps1lon

Loading

ijjk commented Feb 13, 2025 •

edited

Loading

ijjk commented Feb 13, 2025 •

edited

Loading