breaking change!: only ship ESM (and drop Node 18) #264
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Aug 27, 2025
styfle
reviewed
Aug 27, 2025
styfle
approved these changes
Aug 27, 2025
sxzz
reviewed
Oct 7, 2025
sxzz
left a comment
sxzz
left a comment
There was a problem hiding this comment.
I just noticed that the project is using tsdown. The tsdown.config.ts file can be removed, as all options are set to their default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #261
is it happening? is it finally happening? are we shipping a library with only ESM? we must be in the future.