Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-pandas-double.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@chat-adapter/state-redis": patch
---

Fix `createRedisState` typings so `url` appears in IntelliSense and the factory accepts an existing Redis client.
21 changes: 14 additions & 7 deletions packages/state-memory/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { beforeEach, describe, expect, it } from "vitest";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { createMemoryState, type MemoryStateAdapter } from "./index";

describe("MemoryStateAdapter", () => {
Expand Down Expand Up @@ -186,13 +186,20 @@ describe("MemoryStateAdapter", () => {
});

it("should refresh TTL on subsequent appends", async () => {
await adapter.appendToList("list1", { id: 1 }, { ttlMs: 50 });
await new Promise((resolve) => setTimeout(resolve, 30));
// Append again — refreshes TTL
await adapter.appendToList("list1", { id: 2 }, { ttlMs: 50 });
vi.useFakeTimers();

const result = await adapter.getList("list1");
expect(result).toEqual([{ id: 1 }, { id: 2 }]);
try {
await adapter.appendToList("list1", { id: 1 }, { ttlMs: 50 });
await vi.advanceTimersByTimeAsync(30);

// Append again — refreshes TTL
await adapter.appendToList("list1", { id: 2 }, { ttlMs: 50 });

const result = await adapter.getList("list1");
expect(result).toEqual([{ id: 1 }, { id: 2 }]);
} finally {
vi.useRealTimers();
}
});

it("should keep lists isolated by key", async () => {
Expand Down
163 changes: 163 additions & 0 deletions packages/state-redis/src/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { EventEmitter } from "node:events";
import type { Logger } from "chat";
import type { RedisClientType } from "redis";
import { describe, expect, it, vi } from "vitest";
import { createRedisState, RedisStateAdapter } from "./index";

Expand All @@ -22,6 +24,167 @@ describe("RedisStateAdapter", () => {
expect(adapter).toBeInstanceOf(RedisStateAdapter);
});

it("should create an adapter with url and default logger", () => {
const adapter = createRedisState({
url: "redis://localhost:6379",
});

expect(adapter).toBeInstanceOf(RedisStateAdapter);
});

it("should accept an existing redis client", () => {
const client = {
close: vi.fn(),
connect: vi.fn(),
isOpen: true,
isReady: true,
on: vi.fn(),
} as unknown as RedisClientType;

const adapter = createRedisState({
client,
logger: mockLogger,
});

expect(adapter).toBeInstanceOf(RedisStateAdapter);
expect(adapter.getClient()).toBe(client);
});

it("should wait for an injected open client to become ready", async () => {
const emitter = new EventEmitter();
const client = Object.assign(emitter, {
close: vi.fn(),
connect: vi.fn(),
isOpen: true,
isReady: false,
}) as unknown as RedisClientType & {
isReady: boolean;
};

const adapter = createRedisState({
client,
logger: mockLogger,
});

let resolved = false;
const connectPromise = adapter.connect().then(() => {
resolved = true;
});

await Promise.resolve();
expect(resolved).toBe(false);
expect(client.connect).not.toHaveBeenCalled();

client.isReady = true;
emitter.emit("ready");

await connectPromise;
expect(resolved).toBe(true);
});

it("should ignore transient errors while waiting for an injected client to recover", async () => {
const emitter = new EventEmitter();
const client = Object.assign(emitter, {
close: vi.fn(),
connect: vi.fn(),
isOpen: true,
isReady: false,
}) as unknown as RedisClientType & {
isOpen: boolean;
isReady: boolean;
};

const adapter = createRedisState({
client,
logger: mockLogger,
});

let resolved = false;
const connectPromise = adapter.connect().then(() => {
resolved = true;
});

await Promise.resolve();
emitter.emit("error", new Error("Socket closed unexpectedly"));
client.isOpen = false;
emitter.emit("reconnecting");

await Promise.resolve();
expect(resolved).toBe(false);

client.isOpen = true;
client.isReady = true;
emitter.emit("ready");

await connectPromise;
expect(resolved).toBe(true);
expect(client.connect).not.toHaveBeenCalled();
});

it("should wait for an injected client to become ready again after reconnecting", async () => {
const emitter = new EventEmitter();
const client = Object.assign(emitter, {
close: vi.fn(),
connect: vi.fn(),
isOpen: true,
isReady: true,
}) as unknown as RedisClientType & {
isOpen: boolean;
isReady: boolean;
};

const adapter = createRedisState({
client,
logger: mockLogger,
});

await adapter.connect();
expect(client.connect).not.toHaveBeenCalled();

client.isReady = false;
client.isOpen = false;
emitter.emit("reconnecting");

let resolved = false;
const reconnectPromise = adapter.connect().then(() => {
resolved = true;
});

await Promise.resolve();
expect(resolved).toBe(false);
expect(client.connect).not.toHaveBeenCalled();

client.isOpen = true;
client.isReady = true;
emitter.emit("ready");

await reconnectPromise;
expect(resolved).toBe(true);
});

it("should reject when an injected client ends before becoming ready", async () => {
const emitter = new EventEmitter();
const client = Object.assign(emitter, {
close: vi.fn(),
connect: vi.fn(),
isOpen: true,
isReady: false,
}) as unknown as RedisClientType;

const adapter = createRedisState({
client,
logger: mockLogger,
});

const connectPromise = adapter.connect();
const error = new Error("Socket closed unexpectedly");

emitter.emit("error", error);
emitter.emit("end");

await expect(connectPromise).rejects.toBe(error);
});

it("should have appendToList method", () => {
const adapter = createRedisState({
url: "redis://localhost:6379",
Expand Down
Loading
Loading