Skip to content

fix(chat): use adapter to parse channel id #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yjl9903 wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −12
Open

fix(chat): use adapter to parse channel id #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f78314
fix(chat): use adapter to parse channel id
yjl9903 Mar 23, 2026
27e0ee1
test: fix cases use adapter to parse channel id
yjl9903 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/chat/src/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1707,10 +1707,8 @@ export class Chat<
initialMessage: Message,
isSubscribedContext = false
): Thread<TState> {
// Parse thread ID to get channel info
// Format: "adapter:channel:thread"
const parts = threadId.split(":");
const channelId = parts[1] || "";
// Parse thread ID to get channel ID with adapter
const channelId = adapter.channelIdFromThreadId(threadId);

// Check if this is a DM
const isDM = adapter.isDM?.(threadId) ?? false;
Expand Down
8 changes: 4 additions & 4 deletions packages/integration-tests/src/replay-actions-reactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe("Replay Tests - Actions & Reactions", () => {
userId: "U00FAKEUSER1",
userName: "testuser",
adapterName: "slack",
channelId: "C00FAKECHAN1",
channelId: "slack:C00FAKECHAN1",
isDM: false,
});

Expand All @@ -91,7 +91,7 @@ describe("Replay Tests - Actions & Reactions", () => {
added: true,
userId: "U00FAKEUSER1",
adapterName: "slack",
channelId: "C00FAKECHAN1",
channelId: "slack:C00FAKECHAN1",
messageId: "1767326126.896109",
isDM: false,
});
Expand All @@ -110,7 +110,7 @@ describe("Replay Tests - Actions & Reactions", () => {
userId: "U00FAKEUSER1",
userName: "testuser",
adapterName: "slack",
channelId: "C00FAKECHAN1",
channelId: "slack:C00FAKECHAN1",
isDM: false,
});

Expand All @@ -129,7 +129,7 @@ describe("Replay Tests - Actions & Reactions", () => {
userId: "U00FAKEUSER1",
userName: "testuser",
adapterName: "slack",
channelId: "C00FAKECHAN1",
channelId: "slack:C00FAKECHAN1",
isDM: false,
});

Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/src/replay-channel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe("Replay Tests - Channel", () => {
userId: "U00FAKEUSER1",
userName: "testuser",
adapterName: "slack",
channelId: "C00FAKECHAN1",
channelId: "slack:C00FAKECHAN1",
isDM: false,
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/src/replay-modal-private-metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe("Replay Tests - Modal privateMetadata", () => {
userId: "U0A8WUV28QM",
userName: "sd0a90bkva4s_user",
adapterName: "slack",
channelId: "C0A9D9RTBMF",
channelId: "slack:C0A9D9RTBMF",
isDM: false,
});

Expand Down
4 changes: 2 additions & 2 deletions packages/integration-tests/src/replay-modals.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ describe("Replay Tests - Modals", () => {
userId: "U00FAKEUSER2",
userName: "jane.smith",
adapterName: "slack",
channelId: "C00FAKECHAN2",
channelId: "slack:C00FAKECHAN2",
isDM: false,
});

Expand Down Expand Up @@ -254,7 +254,7 @@ describe("Replay Tests - Modals", () => {
expect(capturedAction?.threadId).toBe(
"slack:C00FAKECHAN3:1771126602.612659"
);
expect(capturedAction?.thread?.channelId).toBe("C00FAKECHAN3");
expect(capturedAction?.thread?.channelId).toBe("slack:C00FAKECHAN3");
});

it("should allow editing relatedMessage from ephemeral modal submission", async () => {
Expand Down