fix(test): use unlinkSync to clean up samples/webapp symlink#50
Open
jonchurch wants to merge 1 commit into
Open
fix(test): use unlinkSync to clean up samples/webapp symlink#50jonchurch wants to merge 1 commit into
unlinkSync to clean up samples/webapp symlink#50jonchurch wants to merge 1 commit into
Conversation
|
@jonchurch is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Use
fs.unlinkSyncto remove the symlink, to avoid mac os error on trying tormSynca dir withoutrecursive: true.Wrap
fs.unlinkSyncin try/catch to preserve the previous idempotent behavior ofrmSync(link, {force: true})(swallow any errors if the link is already gone)Why
closes #51
The tests currently fail on mac os with an uncaught error during cleanup.
Error: Path is a directoryMac is choking on the symlink resolving to a dir, so doesnt like
fs.rmSyncwithout{recursive: true}.Verification
pnpm testpassespnpm lintpassespnpm knippasses