fix: discover nested eval result directories#131
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes result discovery for nested eval ids such as
ui-development/design-system/layout-props.saveResultsalready writes nested eval result directories correctly, but housekeeping and reusable-result scanning only looked at immediate children of a timestamp directory. That caused nested results to be treated as incomplete or missed for reuse becausesummary.jsonlives deeper in the tree.Changes
discoverEvalResultDirshelper.housekeepso nested eval result directories are deduped/kept by their full relative eval id.scanReusableResultsso nested evals can match fingerprint keys and be reused.Validation
npm run test -w packages/agent-eval -- src/lib/housekeeping.test.ts src/lib/results.test.tsnpm run build -w packages/agent-evalnpm run lint -w packages/agent-evalCloses #129.