feat: improve names of Docker sandbox containers#128
Open
jonahsnider wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jonah Snider <jonah@jonahsnider.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Docker sandbox backend to generate a name based on the experiment name, eval name, and eval index, instead of the randomly generated Docker container names. Makes it easier to skim through
docker psto try and see which evals are still running.@vercel/sandboxhas support for names and tags but only in beta, I'm happy to add that in if desired, but it'd mean upgrading to v2 of the package.