fix: clean up Docker sandbox containers on exit#127
Open
jonahsnider wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jonah Snider <jonah@jonahsnider.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Thanks so much for making agent-eval and open sourcing it. I've been using it for some of our own internal evals at Sanity and it's been great so far. Since we use Docker to run our evals, I noticed a few things that could be improved for local DX when running evals through Docker.
This PR makes it so that sandbox containers started via Docker are cleaned up (or at least cleanup is attempted) when the CLI exits. I noticed that after running
ctrl + cwhile running evals locally, the sandbox containers were still running in the background. This should fix that, preventing stale Docker containers from piling up.