Skip to content

Fix case when not properly considering missing xmp entry #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximPlusov merged 2 commits into from
Dec 8, 2025
Merged

Fix case when not properly considering missing xmp entry #721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f600ab9
Fix case when not properly considering missing xmp entry
LonelyMidoriya Dec 8, 2025
df3305d
Update GFCosInfo.java
LonelyMidoriya Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions validation-model/src/main/java/org/verapdf/gf/model/impl/cos/GFCosInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,36 +203,42 @@ public String getXMPDescription() {

@Override
public Boolean getdoCreationDatesMatch() {
String creationDate = getCreationDate();
if (creationDate == null) {
return null;
}
Calendar xmpCreateDate = null;
if (meta != null) {
try {
xmpCreateDate = meta.getCreateDate();
} catch (XMPException ignored) {
}
}
String creationDate = getCreationDate();
if (xmpCreateDate != null && creationDate != null) {
if (xmpCreateDate != null) {
Calendar creationDateCalendar = TypeConverter.parseDate(creationDate);
return creationDateCalendar != null && xmpCreateDate.compareTo(creationDateCalendar) == 0;
}
return null;
return false;
}

@Override
public Boolean getdoModDatesMatch() {
String modDate = getModDate();
if (modDate == null) {
return null;
}
Calendar xmpModifyDate = null;
if (meta != null) {
try {
xmpModifyDate = meta.getModifyDate();
} catch (XMPException ignored) {
}
}
String modDate = getModDate();
if (xmpModifyDate != null && modDate != null) {
if (xmpModifyDate != null) {
Calendar modDateCalendar = TypeConverter.parseDate(modDate);
return modDateCalendar != null && xmpModifyDate.compareTo(modDateCalendar) == 0;
}
return null;
return false;
}

@Override
Expand Down
Loading