fix(doctor): Verify-loop check agrees with the wired --loop hook (v0.7.1)#30
Merged
youcefzemmar merged 1 commit intoMay 31, 2026
Merged
Conversation
The "Verify loop" check read only config.loop.enabled, so after `setup` (which installs `hook --loop`) doctor could print "Verify loop: off" right below "Stop hook: ... verify loop on" — a contradiction. It now reports the loop on when the wired hook command carries --loop or config enables it. Caught by an independent verification pass. +1 test (151 pass). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29. An independent verification pass found that
doctor's Verify loop check read onlyconfig.loop.enabled, so aftersetup(which installshook --loop) it could print "Verify loop: off" directly below "Stop hook: … verify loop on" — a contradiction in a brand-new headline command.Now it reports the loop on when the wired hook carries
--loopOR config enables it (on (hook --loop)/on (config)). Cosmetic only; +1 regression test. 151 tests pass. Ships as 0.7.1.🤖 Generated with Claude Code