Exclude "sync" and "time" as duplicate imports.#55
Open
vanjiii wants to merge 2 commits intovektah:masterfrom
Open
Exclude "sync" and "time" as duplicate imports.#55vanjiii wants to merge 2 commits intovektah:masterfrom
vanjiii wants to merge 2 commits intovektah:masterfrom
Conversation
olegbolden
added a commit
to olegbolden/dataloaden
that referenced
this pull request
Apr 9, 2024
olegbolden
added a commit
to olegbolden/dataloaden
that referenced
this pull request
Apr 9, 2024
Exclude "sync" and "time" as duplicate imports. vektah#55
viocle-kvanek
added a commit
to viocle/dataloaden
that referenced
this pull request
Oct 8, 2025
…ows to use Go versions 1.24 and 1.25. Update CircleCI config to use Go 1.25. Exclude "sync" and "time" as duplicate imports. vektah#55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54
Basically exclude sync and time packages from being second time imported while generating the *gen.go file.
Example given:
//go:generate dataloaden fooLoader int *time.Time