Seperate base vesc-express from specific device implementations#79
Seperate base vesc-express from specific device implementations#79mvturnho wants to merge 6 commits intovedderb:mainfrom
Conversation
Removed Assist specific HW_NAME
|
I think a lot of things could be done with LISP. You can copy the implementation for creating a custom config from VBMS. There's really no need to add any more weird functions. |
Hi, Thanks for your reply. The PR is not about lisp. It's about making the base vesc-express code suitable to make implementations using the components. So when we want to support an esp32c6 with a display and a different imu we do not add the drivers and lvgl code to vesc-express but implement a new component that uses the vesc-express code foor the base functionality. The implementation has the nescesary drivers and makes its own settings, config_main_t etc. |
I 100% agree with this. Most of this can be done in lisp and if you need anything extra that can be done in the hwconf for your hardware. If we want to support more SOCs we can do that similar to how the ESP32-S3 implementation was done. |
I am working on a assist module based on an esp32s3. it implements speed sensor, pas sensor, assist levels brake sensort etc. It controls the VESC motor over canbus using current and rpm frames.
Now in the current vesc-express we have the hwconf for every different type of device/bord. I think it would greatly reduce code complexity when we move the specific implementations to the components of esp-idf.
To be able to do this we need some changes in the base vesc-express code. That is what is in this pull request.
We need to be able to compile the components and use the specific config settings (settings.xml) for the device. Then the base vesc-express code should also make it possible to use an aditional decode message for can-frames. The lispbm extension is already available to be extended from the component just like the terminal commands.