Added npm build and tests to CI #2
Open
+53
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI improvements: - Added concurrency settings to cancel in-progress runs - Renamed sdk-tests → python-sdk-tests - Added node-sdk-tests job with npm caching - Added npm caching to release workflow Bug fix in sdk/node/src/index.ts: - Fixed cross-platform which/where detection that was creating a nul file
nicoloboschi
approved these changes
Dec 15, 2025
Collaborator
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
LGTM
But I have plans to distribute the binary inside the npm package as we do for python now, also we don't have the npm package yet (as we don't need it for our projects for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI improvements:
Bug fix in sdk/node/src/index.ts: