Skip to content

chore(gcp chronicle sink): remove timberio/chronicle-emulator#25670

Open
pront wants to merge 1 commit into
masterfrom
pront/remove-chronicle-emulator
Open

chore(gcp chronicle sink): remove timberio/chronicle-emulator#25670
pront wants to merge 1 commit into
masterfrom
pront/remove-chronicle-emulator

Conversation

@pront

@pront pront commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

Removes the timberio/chronicle-emulator hosted Docker image from the GCP integration test suite.

  • The two end-to-end tests (publish_events, publish_invalid_events) were already #[ignore]d pointing to Some gcp tests fail #24133 — they are dropped here since they had no coverage value in their disabled state.
  • invalid_credentials is converted to a self-contained unit test using wiremock to mock the OAuth token endpoint returning 401, so it no longer requires the emulator at all.

Vector configuration

N/A — no user-facing behavior change.

How did you test this PR?

cargo test -p vector --features "sinks-gcp" -- gcp_chronicle

New unit test passes locally without any external service.

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Replace the two ignored integration tests (publish_events, publish_invalid_events)
with nothing — they are tracked in #24133. Convert invalid_credentials into a
self-contained unit test using wiremock to mock the OAuth token endpoint, eliminating
the need for the hosted timberio/chronicle-emulator Docker image.
@pront pront mentioned this pull request Jun 23, 2026
@github-actions github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Jun 23, 2026
@pront pront marked this pull request as ready for review June 23, 2026 20:22
@pront pront requested a review from a team as a code owner June 23, 2026 20:22
@datadog-vectordotdev

datadog-vectordotdev Bot commented Jun 23, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 1 Pipeline job failed

Changelog | validate-changelog   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4122fd1 | Docs | Give us feedback!

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 23, 2026
@pront pront enabled auto-merge June 23, 2026 20:55
@pront pront added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants