chore(clippy): add workspace lints string_slice, await_holding_lock, let_underscore_must_use#25668
Closed
pront wants to merge 1 commit into
Closed
chore(clippy): add workspace lints string_slice, await_holding_lock, let_underscore_must_use#25668pront wants to merge 1 commit into
pront wants to merge 1 commit into
Conversation
github-actions
Bot
added
domain: sources
This comment has been minimized.
This comment has been minimized.
pront
added
no-changelog
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08b65a29e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…let_underscore_must_use Adds three opt-in clippy lints to [workspace.lints.clippy] so they apply across all workspace crates: - string_slice: catches &str[n..] byte-index slicing that can panic on multi-byte UTF-8 boundaries (the direct cause of the bug fixed in #25582) - await_holding_lock: catches .await while holding a MutexGuard (potential deadlock) - let_underscore_must_use: catches let _ = expr where expr has a #[must_use] type or return value All existing violations are resolved: real fixes preferred (strip_prefix, split_once, split_at, .ok()), with targeted #[expect] or #![allow] reserved for provably-safe patterns (regex/find() indices, Derivative macro false positives) and one genuine unavoidable case (kinesis partition_key truncation via floor_char_boundary). Also fixes a latent panic in aws_kinesis sink: partition_key[..256] could panic on multi-byte keys; replaced with floor_char_boundary(256).
pront
force-pushed
the
pavlos/workspace-clippy-lints
branch
from
f224db7 to
e3640eb
Compare
github-actions
Bot
added
domain: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#25669