chore(tests): Change liveness check for eventually_conservation#25667
Merged
blt merged 1 commit intoJun 23, 2026
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
The previous version of eventually_conservation relied on polling /metrics to infer whether or not the data topology in the scenarios were active. This inference is a race, metrics/ might report while the source/sink are still coming online, so in a small number of cases scenarios failed on this race. The approach taken here is to bump the "is it back online" check to 180s and poll directly on the topology, not on /metrics. I've taken the opportunity to slim vector_e2e a little further also, removing vestigial restart config update material. This rare failure will be fixed in the disk buffer scenario as well.
1acec98 to
610b1ef
Compare
9 tasks
pront
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The previous version of eventually_conservation relied on polling /metrics to infer
whether or not the data topology in the scenarios were active. This inference is a
race, metrics/ might report while the source/sink are still coming online, so in a
small number of cases scenarios failed on this race. The approach taken here is to
bump the "is it back online" check to 180s and poll directly on the topology, not
on /metrics. I've taken the opportunity to slim vector_e2e a little further also,
removing vestigial restart config update material.
This rare failure will be fixed in the disk buffer scenario as well.
Vector configuration
How did you test this PR?
Antithesis scenario run cycle.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.