Skip to content

chore(tests): Change liveness check for eventually_conservation#25667

Merged
blt merged 1 commit into
masterfrom
blt/change_liveness_check_for_eventually_conservation
Jun 23, 2026
Merged

chore(tests): Change liveness check for eventually_conservation#25667
blt merged 1 commit into
masterfrom
blt/change_liveness_check_for_eventually_conservation

Conversation

@blt

@blt blt commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

The previous version of eventually_conservation relied on polling /metrics to infer
whether or not the data topology in the scenarios were active. This inference is a
race, metrics/ might report while the source/sink are still coming online, so in a
small number of cases scenarios failed on this race. The approach taken here is to
bump the "is it back online" check to 180s and poll directly on the topology, not
on /metrics. I've taken the opportunity to slim vector_e2e a little further also,
removing vestigial restart config update material.

This rare failure will be fixed in the disk buffer scenario as well.

Vector configuration

How did you test this PR?

Antithesis scenario run cycle.

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

blt commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@datadog-vectordotdev

datadog-vectordotdev Bot commented Jun 22, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 610b1ef | Docs | Give us feedback!

@blt blt changed the title Change liveness check for eventually_conservation chore(tests): Change liveness check for eventually_conservation Jun 22, 2026
@blt blt added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 22, 2026
@blt blt marked this pull request as ready for review June 22, 2026 21:07
@blt blt requested review from a team as code owners June 22, 2026 21:07
The previous version of eventually_conservation relied on polling /metrics to infer
whether or not the data topology in the scenarios were active. This inference is a
race, metrics/ might report while the source/sink are still coming online, so in a
small number of cases scenarios failed on this race. The approach taken here is to
bump the "is it back online" check to 180s and poll directly on the topology, not
on /metrics. I've taken the opportunity to slim vector_e2e a little further also,
removing vestigial restart config update material.

This rare failure will be fixed in the disk buffer scenario as well.
@blt blt force-pushed the blt/change_liveness_check_for_eventually_conservation branch from 1acec98 to 610b1ef Compare June 22, 2026 21:08
@blt blt added this pull request to the merge queue Jun 23, 2026
Merged via the queue into master with commit c0cc69c Jun 23, 2026
85 checks passed
@blt blt deleted the blt/change_liveness_check_for_eventually_conservation branch June 23, 2026 14:29
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants