feat(vector sink): add multiple endpoint strategies#25662
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7499cf772
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
d7499cf to
25ceca6
Compare
|
Addressed the review comments in the latest push (
Validation rerun:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25ceca6c6f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
25ceca6 to
75fcbe3
Compare
|
Updated the branch to address the latest review comments:
Validation:
|
Summary
Adds multi-endpoint support to the
vectorsink:addresses = [...]configures multiple downstream Vector endpointsendpoint_strategy = "load_balance"is the default and uses the existing distributed service / endpoint-health pathendpoint_strategy = "failover"uses ordered, non-preemptive failover for stateful downstream Vector aggregatorsaddress = "..."behavior unchangedThe failover strategy starts with the first configured endpoint, moves to the next endpoint on request failure or per-endpoint timeout, and keeps using the successful endpoint until it fails. Hosts can use different address ordering to spread primary ownership without requiring random failover semantics.
Validation
make generate-component-docscargo fmt --all -- --checkcargo test --no-default-features --features sinks-vector --lib sinks::vector::tests::cargo test --no-default-features --features sinks-vector --lib sinks::vector::test::generate_configcargo clippy --no-default-features --features sinks-vector --lib -- -D warnings -A clippy::manual_option_zip./scripts/check_changelog_fragments.shload_balancedelivered events to both downstream Vector serversfailoverdelivered only to the first endpoint while healthy, then moved to the second endpoint after the first was stopped with boundedrequest.timeout_secs