Remove floor fillet for efloor mode [1]#39
Open
danielsan80 wants to merge 1 commit intovector76:mainfrom
Open
Conversation
|
I don't think @vector76 is still working on this project. Gridfinity extended which is built on this library is still active. |
Author
|
Ah ok. I didn't find your repo before. I'll switch to your project very soon. |
Author
|
UPDATE: This issue was solved by @ostat in his project https://github.com/ostat/gridfinity_extended_openscad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jamie.
This is my first attempt to contributing to the project to get more familiar with it.
Maybe it's just my personal taste, so feel free to reject this PR.
In
efloormode, you dig the standard floor which has a spherical fillet, but I'm not sure a filleted floor inner edge is functional in this case.In my opinion, a sharpen inner edge might be more effective.
To try the change, in
gridfinity_basic_cup.scad, set:Thanks for your job.