Skip to content

chore: add node best block metrics#1518

Closed
darrenkel wants to merge 72 commits intomasterfrom
darren/chore/node-add-metrics
Closed

chore: add node best block metrics#1518
darrenkel wants to merge 72 commits intomasterfrom
darren/chore/node-add-metrics

Conversation

@darrenkel
Copy link
Copy Markdown
Contributor

@darrenkel darrenkel commented Dec 5, 2025

Description

add gauges to easily record best block metrics

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

vanja-vechain and others added 30 commits November 7, 2025 15:59
@vanja-vechain @libotony
Add underflow check (#1332)
71be33c
@paologalligit @freemanzMrojo @libotony
increase coverage test (#1333)
8546710 
Co-authored-by: Miguel Angel Rojo <freemanz1486@gmail.com>
@freemanzMrojo @libotony
chore: GetMaxBlockProposers extracted (#1331)
df1673d 
* minor changes

* minor changes

* minor changes

* change

* extracted method to params

* lint
@freemanzMrojo @libotony
test: increased coverage (#1337)
cf0cd27 
* unit tests

* license check
@paologalligit @libotony
refactor ci/cd to build the docker image separately (#1341)
e001c6d
@paologalligit @libotony
Paolo/coverage 2 (#1369)
d0a5287 
* improve coverage

* improve coverage builtin/staker package
@YeahNotSewerSide @libotony
Andrew/feat/return build version (#1385)
31c33b7 
* update version string on startup

* fix linting

* move commit from version to description

* add version meta

* add templating
@darrenkel @libotony
refactor(staker): migrate more tests (#1365)
c261132
@libotony
fix: missing cherry pick changes
072636c
@darrenkel @libotony
refactor(staker): migrate tests (#1374)
6055ae8
@vanja-vechain @libotony
Packer loop refactor (#1375)
ecfed82 
* Packer loop refactor

* extract commitBlock in cmd/thor/node (#1370)

* Add tests

---------

Co-authored-by: libotony <tony.li@vechain.org>
@darrenkel @libotony
chore(thorclient): add godoc comments (#1388)
7afa380
@vanja-vechain @paologalligit
@otherview @libotony
Add complex scenarios tests (#1410)
7e71e47 
* remove redundant gas consumption call (#1407)

* Fix hayabusa solo mode for executor actions (#1409)

* Add complex scenarios tests

* Fix linting issues

* Adjust to 2.4.1

---------

Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
@vanja-vechain @paologalligit
@otherview @libotony
Vanja/feat/complex scenarios tests (#1412)
4bf4f2e 
* remove redundant gas consumption call (#1407)

* Fix hayabusa solo mode for executor actions (#1409)

* Add complex scenarios tests

* Fix linting issues

* Adjust to 2.4.1

* add delegation complex scenarios

---------

Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
@darrenkel @libotony
fix(ci): build solo first then run (#1386)
7bf10e3
@libotony @vanja-vechain
add raw storage retrieve api (#1395)
818cdcc 
* add raw storage retrieve api

* lint

* Add to client, add tests

* Add comment

* fix test

---------

Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
@vanja-vechain @paologalligit
@otherview @libotony
Vanja/feat/complex scenarios tests (#1418)
54cb8c1 
* remove redundant gas consumption call (#1407)

* Fix hayabusa solo mode for executor actions (#1409)

* Add complex scenarios tests

* Fix linting issues

* Adjust to 2.4.1

* add delegation complex scenarios

* add combination scenarios

---------

Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
@libotony
fix tests after cherry pick
48e2353
@libotony
clean up in packer loop (#1458)
edd16f3
@freemanzMrojo @vanja-vechain
@paologalligit @darrenkel @YeahNotSewerSide @libotony @otherview
chore(docs): command line arguments (#1448)
b1ee2f2 
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com>
Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com>
Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com>
Co-authored-by: libotony <tony.li@vechain.org>
Co-authored-by: Darren Kelly <darren.kelly@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
@freemanzMrojo @vanja-vechain
@paologalligit @darrenkel @YeahNotSewerSide @libotony @otherview
chore(ci): remove unused trigger_internal_ci (#1453)
a73a835 
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com>
Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com>
Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com>
Co-authored-by: libotony <tony.li@vechain.org>
Co-authored-by: Darren Kelly <darren.kelly@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
@freemanzMrojo @libotony
chore: extra uint64/int validations (#1457)
69ca3c6
@freemanzMrojo @libotony
fix(solo): big int value comparison (#1460)
1d5ec5c
@freemanzMrojo @vanja-vechain
@paologalligit @darrenkel @YeahNotSewerSide @libotony @otherview
chore(api): align clause types (#1416)
6d832f1 
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com>
Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com>
Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com>
Co-authored-by: libotony <tony.li@vechain.org>
Co-authored-by: Darren Kelly <darren.kelly@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
Co-authored-by: tony <liboliqi@gmail.com>
@freemanzMrojo @vanja-vechain
@paologalligit @darrenkel @YeahNotSewerSide @libotony @otherview
chore(thorclient): split txpool methods (#1419)
47a2e25 
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com>
Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com>
Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com>
Co-authored-by: libotony <tony.li@vechain.org>
Co-authored-by: Darren Kelly <darren.kelly@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
Co-authored-by: tony <liboliqi@gmail.com>
@darrenkel @libotony
chore: add go 1.25 go test suite (#1469)
3226ee2
@paologalligit @libotony
Priority price fix (#1468)
7e0b79b
@freemanzMrojo @vanja-vechain
@paologalligit @darrenkel @YeahNotSewerSide @libotony @otherview
fix(abi): constructor should not use selector to encode/decode (#1417)
63a6b88 
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com>
Co-authored-by: Paolo Galli <paolo.galli@vechain.org>
Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com>
Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com>
Co-authored-by: libotony <tony.li@vechain.org>
Co-authored-by: Darren Kelly <darren.kelly@vechain.org>
Co-authored-by: Pedro Gomes <otherview@gmail.com>
Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
Co-authored-by: tony <liboliqi@gmail.com>
@otherview @libotony
Pedro/hayabusa/permutation test v2.4.1 (#1472)
995202f
@darrenkel @libotony
fix: release CI, thor.yaml contains double version (#1474)
be5e848
@darrenkel darrenkel requested a review from a team as a code owner December 5, 2025 12:30
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

paologalligit
paologalligit previously approved these changes Dec 10, 2025
View reviewed changes
@darrenkel darrenkel changed the base branch from release/v2.4.1-old to release/v2.4.1 January 5, 2026 09:21
@darrenkel darrenkel dismissed paologalligit’s stale review January 5, 2026 09:21

The base branch was changed.

@darrenkel darrenkel changed the base branch from release/v2.4.1-last to master January 15, 2026 12:22
@darrenkel darrenkel closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paologalligit paologalligit paologalligit left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@darrenkel @codecov-commenter @paologalligit @vanja-vechain @freemanzMrojo @YeahNotSewerSide @libotony @otherview @moglu2017 @David-O-M