Darren/feat/use latest abi fucntionality#1501
Closed
Conversation
Co-authored-by: Miguel Angel Rojo <freemanz1486@gmail.com>
* minor changes * minor changes * minor changes * change * extracted method to params * lint
* unit tests * license check
* improve coverage * improve coverage builtin/staker package
* update version string on startup * fix linting * move commit from version to description * add version meta * add templating
* Packer loop refactor * extract commitBlock in cmd/thor/node (#1370) * Add tests --------- Co-authored-by: libotony <tony.li@vechain.org>
* remove redundant gas consumption call (#1407) * Fix hayabusa solo mode for executor actions (#1409) * Add complex scenarios tests * Fix linting issues * Adjust to 2.4.1 * add delegation complex scenarios --------- Co-authored-by: Paolo Galli <paolo.galli@vechain.org> Co-authored-by: Pedro Gomes <otherview@gmail.com>
* add raw storage retrieve api * lint * Add to client, add tests * Add comment * fix test --------- Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
* remove redundant gas consumption call (#1407) * Fix hayabusa solo mode for executor actions (#1409) * Add complex scenarios tests * Fix linting issues * Adjust to 2.4.1 * add delegation complex scenarios * add combination scenarios --------- Co-authored-by: Paolo Galli <paolo.galli@vechain.org> Co-authored-by: Pedro Gomes <otherview@gmail.com>
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com> Co-authored-by: Paolo Galli <paolo.galli@vechain.org> Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com> Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com> Co-authored-by: libotony <tony.li@vechain.org> Co-authored-by: Darren Kelly <darren.kelly@vechain.org> Co-authored-by: Pedro Gomes <otherview@gmail.com> Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com> Co-authored-by: Paolo Galli <paolo.galli@vechain.org> Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com> Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com> Co-authored-by: libotony <tony.li@vechain.org> Co-authored-by: Darren Kelly <darren.kelly@vechain.org> Co-authored-by: Pedro Gomes <otherview@gmail.com> Co-authored-by: vanjatomic <vanja.tomic@vechain.org>
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com> Co-authored-by: Paolo Galli <paolo.galli@vechain.org> Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com> Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com> Co-authored-by: libotony <tony.li@vechain.org> Co-authored-by: Darren Kelly <darren.kelly@vechain.org> Co-authored-by: Pedro Gomes <otherview@gmail.com> Co-authored-by: vanjatomic <vanja.tomic@vechain.org> Co-authored-by: tony <liboliqi@gmail.com>
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com> Co-authored-by: Paolo Galli <paolo.galli@vechain.org> Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com> Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com> Co-authored-by: libotony <tony.li@vechain.org> Co-authored-by: Darren Kelly <darren.kelly@vechain.org> Co-authored-by: Pedro Gomes <otherview@gmail.com> Co-authored-by: vanjatomic <vanja.tomic@vechain.org> Co-authored-by: tony <liboliqi@gmail.com>
Co-authored-by: vanja-vechain <122791588+vanja-vechain@users.noreply.github.com> Co-authored-by: Paolo Galli <paolo.galli@vechain.org> Co-authored-by: Darren Kelly <107671032+darrenvechain@users.noreply.github.com> Co-authored-by: YeahNotSewerSide <47860375+YeahNotSewerSide@users.noreply.github.com> Co-authored-by: libotony <tony.li@vechain.org> Co-authored-by: Darren Kelly <darren.kelly@vechain.org> Co-authored-by: Pedro Gomes <otherview@gmail.com> Co-authored-by: vanjatomic <vanja.tomic@vechain.org> Co-authored-by: tony <liboliqi@gmail.com>
…1526) Co-authored-by: David-O-M <David-O-M@David-O-M.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POC PR to demo new abi functionality. See POC here: https://github.com/vechain/thor/compare/darren/feat/use-latest-abi-fucntionality...darren/demo/new-abi-demo?expand=1
To copies the ABI package from go-ethereum, with minor changes for
math.U256Bytessince the function does not exist in go-ethereum v1.8.x: https://github.com/vechain/thor/blob/darren/feat/use-latest-abi-fucntionality/abi/ethabi/pack.go#L98Checklist: