Interface logsdb

[otherview]

Description

Interfaces the logdb package that was implemented by sqlite3 into logsdb and implementation into sqlite3.

Fixes # (issue)

Type of change

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• New and existing E2E tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have not added any vulnerable dependencies to my code

[darrenkel]

generally its bad practice for a child package to depend on its parent

[otherview]

Should be ok for defining models and interfaces, it's a used pattern, but I agree it's code smell for implementations.

I can likely move the sql-ish implementations of the models into an interface as well and let sqllite implement.

[otherview]

Moved the sql deps to sqlite3 now following the same pattern as api.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 66.38655% with 40 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cmd/thor/sync_logdb.go	0.00%	19 Missing ⚠️
api/events_types.go	58.33%	5 Missing ⚠️
cmd/thor/utils.go	0.00%	5 Missing ⚠️
logsdb/metrics.go	0.00%	3 Missing ⚠️
logsdb/sqlite3/query_builder.go	89.28%	2 Missing and 1 partial ⚠️
logsdb/sqlite3/logdb.go	92.85%	2 Missing ⚠️
api/transfers_types.go	0.00%	1 Missing ⚠️
cmd/thor/main.go	0.00%	1 Missing ⚠️
thorclient/bind/filter.go	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!