Replace usages of depth buffer with depth attachment#62
Open
martty wants to merge 6 commits intovblanco20-1:masterfrom
Open
Replace usages of depth buffer with depth attachment#62martty wants to merge 6 commits intovblanco20-1:masterfrom
martty wants to merge 6 commits intovblanco20-1:masterfrom
Conversation
Owner
|
Im not sure such a rename is a good thing, depth buffer is how everyone generally calls it, even if depth attachment is more accurate. |
Contributor
Author
|
Obviously not everybody, since Vulkan itself doesn't call it that - and this is a Vulkan tutorial. There is no point in teaching old language, it is just confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depth buffer is an old term and not used by the Vulkan specification. The guide is clearer by not using it as well, improving the searchability of the term.
Also fixed a few typos I saw as I was editing.