Fixed PR: Minor typo fixes and other proofreading for vulkan_new_rendering.md#147
Open
FireflyInTheDusk wants to merge 2 commits intovblanco20-1:masterfrom
Open
Fixed PR: Minor typo fixes and other proofreading for vulkan_new_rendering.md#147FireflyInTheDusk wants to merge 2 commits intovblanco20-1:masterfrom
vulkan_new_rendering.md#147FireflyInTheDusk wants to merge 2 commits intovblanco20-1:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured that while going through the tutorial I could also help out by fixing typos and such whenever I saw an opportunity.
This is a first pass into "Improving the render loop"
I changed PCSX3 to RPCS3, I think that's what was intended in the first place right? I don't think there ever was a PCSX3 emulator, and RPCS3 is indeed listed as a user of VMA.
Would be cool if we could link to an article or blog post or something else that mentions the framerate improvement, I couldn't find any after a quick search tho.