Centralize TypeScript types by overloading them in class definitions#1
Open
MortallicaXxX wants to merge 3 commits intovaultys:mainfrom
Open
Centralize TypeScript types by overloading them in class definitions#1MortallicaXxX wants to merge 3 commits intovaultys:mainfrom
MortallicaXxX wants to merge 3 commits intovaultys:mainfrom
Conversation
Deleted src/types.ts and refactored code in src/index.ts and src/plakar.ts to inline or locally define types previously imported from types.ts. This simplifies the codebase by reducing indirection and consolidating type definitions.
Moved InstallOptions, InstallResult, and CheckResult interfaces into a PlakarInstaller namespace for better encapsulation and type organization. Updated all references to use the new namespaced types. Removed direct exports of these types from the installer module.
Feature/plakar types overload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
PlakarCLI codebase, focusing on simplifying the exports, restructuring thePlakarInstallermodule, and removing thetypesfile entirely. The most notable updates include the creation of a namespace forPlakarInstaller, renaming several interfaces for clarity, and removing unused type definitions.Simplification of exports:
src/index.ts] : Removed the export oftypesand streamlined the export of installation utilities by omitting type definitions from the export list.Restructuring of
PlakarInstaller:src/installer.ts]: Introduced aPlakarInstallernamespace to encapsulate related interfaces (Options,Result, andCheckResult) and methods. Updated all references to use the namespace for better organization and readability.Removal of
typesfile:src/types.ts]: Deleted the file entirely, removing numerous type definitions that were no longer in use or necessary, such asCommonOptions,Repository, andSnapshot.