Skip to content

feat: implement webhook setup call parsing and response handling#30

Open
ag84ark wants to merge 1 commit into
mainfrom
fix/fix-webhook-parse-for-test-call-when-declaring-webhook
Open

feat: implement webhook setup call parsing and response handling#30
ag84ark wants to merge 1 commit into
mainfrom
fix/fix-webhook-parse-for-test-call-when-declaring-webhook

Conversation

@ag84ark
Copy link
Copy Markdown
Contributor

@ag84ark ag84ark commented May 29, 2026

Implementing the webhook using Webhook::parse(...) would fail on the initial setup on the website, as it sends a test call to see if it's working.
In this PR we take care of that call as well, as now it would return a 422.

@sandervanhooft Also need to publish after merge.

@ag84ark ag84ark requested a review from sandervanhooft May 29, 2026 14:07
@ag84ark ag84ark self-assigned this May 29, 2026
@ag84ark
Copy link
Copy Markdown
Contributor Author

ag84ark commented May 29, 2026

I think this also influences vatly-fluent-php if your not using the functionality from here directly

@sandervanhooft
Copy link
Copy Markdown
Member

Superseded by the follow-up work. PR #30 targeted the temporary setup-call payload shape, but the backend now emits a standard event, so the replacement removes the special-case parser path and handles setup deliveries as ordinary objects.

@sandervanhooft
Copy link
Copy Markdown
Member

Superseded by the follow-up feat/webhook-setup-event-v1 work. PR #30 targeted the temporary setup-call payload shape, but the backend now emits a standard webhook.setup event, so the replacement removes the special-case parser path and handles setup deliveries as ordinary WebhookPayload objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants