feat: implement webhook setup call parsing and response handling#30
Open
ag84ark wants to merge 1 commit into
Open
feat: implement webhook setup call parsing and response handling#30ag84ark wants to merge 1 commit into
ag84ark wants to merge 1 commit into
Conversation
Contributor
Author
|
I think this also influences |
Member
|
Superseded by the follow-up work. PR #30 targeted the temporary setup-call payload shape, but the backend now emits a standard event, so the replacement removes the special-case parser path and handles setup deliveries as ordinary objects. |
Member
|
Superseded by the follow-up feat/webhook-setup-event-v1 work. PR #30 targeted the temporary setup-call payload shape, but the backend now emits a standard webhook.setup event, so the replacement removes the special-case parser path and handles setup deliveries as ordinary WebhookPayload objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the webhook using Webhook::parse(...) would fail on the initial setup on the website, as it sends a test call to see if it's working.
In this PR we take care of that call as well, as now it would return a 422.
@sandervanhooft Also need to publish after merge.