add ability to pass a constructor as controlType#11
Open
RaulPROP wants to merge 8 commits intovasturiano:masterfrom
Open
add ability to pass a constructor as controlType#11RaulPROP wants to merge 8 commits intovasturiano:masterfrom
RaulPROP wants to merge 8 commits intovasturiano:masterfrom
Conversation
Owner
|
@RaulPROP thanks for this PR! Would you mind removing all the code style changes (spacing, ' > ", etc) so that we can get a better feel for what the real code changes are? |
Contributor
Author
|
Sorry, I'm used to hit the lint command way too often. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here, I added the ability to pass a function as the constructor for the controller.
The only thing that is not tackled is the
navInfotext.