Skip empty Turn Lists in the Turn Counter#14483
Open
rlament wants to merge 1 commit intovassalengine:masterfrom
Open
Skip empty Turn Lists in the Turn Counter#14483rlament wants to merge 1 commit intovassalengine:masterfrom
rlament wants to merge 1 commit intovassalengine:masterfrom
Conversation
Module designers can unintentionally or intentionally add an empty list turn object to the turn tracker. The item list initializes as empty by default. The turn tracker should not throw exceptions on empty lists. Since the list has no levels, the turn counter skips over empty turn lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module designers can unintentionally or intentionally add an empty Turn List sub-component to a Turn Counter button. A new Turn List initializes as empty by default with no levels.
This PR adds handling of empty turn lists. The turn tracker should not throw exceptions on empty lists when advancing to the next or previous list item. For any list without defined levels or sub-levels, the turn counter skips over those empty turn lists.
Closes #14471