14237 Fix Symbolic Dice Button atomic undo#14386
Open
rlament wants to merge 1 commit intovassalengine:release-3.7from
Open
14237 Fix Symbolic Dice Button atomic undo#14386rlament wants to merge 1 commit intovassalengine:release-3.7from
rlament wants to merge 1 commit intovassalengine:release-3.7from
Conversation
Expand ShowResults command to include old (previous) values similar to ChangePropertyCommand implementation to sync undo operations by the remote end in online play. Add prepareActionsCommand() function which is invoked as an initialization function by doActions().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded ShowResults command to include the previous roll(s) using the ChangePropertyCommand as an example. Despite the addition, ShowResults remains backward compatible. Including the previous roll(s) in the command allows remote undo during online play. The parameter list and member variables of the ShowResults command follow the ChangePropertyCommand convention.
Made the construction of SpecialDiceButton class a litle bit more object oriented no longer requiring a special constructor to by-pass base class initialization. Added the prepareActionsCommand() function as a precursor to doActions() permitting child classes to perform custom setup. Deprecated the DR() function at the same time making it an empty function.
Tested pre/post commands with looping for online, standalone and log playback.
For proper update of dice properties during online play, PR #14382 is required.
Closes #14237