Closed
Conversation
Collaborator
|
@cholmcc - is this ready for review and merge into upcoming release 3.7.19 ? |
Contributor
Author
I believe so. |
Instead of using the map centre, which is limited by the view port, use the previously user requested map centre - i.e., `Map#getPreferredCenter`. This will ensure that more pieces are seen when cycling through pieces. Note that the algorithm is still broken in so far at it never will visit _all_ pieces selected by the selection criteria. To make the algorithm visit _all_ pieces, it would have to keep some state information between invocations.
cholmcc
force-pushed
the
cholmcc_move_camera
branch
from
1299b84 to
72dd0e9
Compare
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using the map centre, which is limited by the view port, use the previously user requested map centre - i.e.,
Map#getPreferredCenter. This will ensure that more pieces are seen when cycling through pieces.Note that the algorithm is still broken in so far at it never will visit all pieces selected by the selection criteria.
To make the algorithm visit all pieces, it would have to keep some state information between invocations.