Add restrictRange attribute to DeckGlobalKeyCommand#14300
Open
gantoin wants to merge 1 commit intovassalengine:masterfrom
Open
Add restrictRange attribute to DeckGlobalKeyCommand#14300gantoin wants to merge 1 commit intovassalengine:masterfrom
gantoin wants to merge 1 commit intovassalengine:masterfrom
Conversation
rlament
reviewed
Nov 5, 2025
Comment on lines
+329
to
+331
| else { | ||
| return new NullCommand(); | ||
| } |
Contributor
There was a problem hiding this comment.
Should this 'else' block be deleted? It seems that decks may not necessarily have an associated map. In that case shouldn't this function continue with the original behavior and apply only to pieces in the deck. In other words, not return here.
rlament
reviewed
Nov 5, 2025
| Editor.DeckGlobalKeyCommand.command=Global Command | ||
| Editor.DeckGlobalKeyCommand.matching_properties=Matching expression | ||
| Editor.DeckGlobalKeyCommand.affects=Affects | ||
| Editor.DeckGlobalKeyCommand.restrict_range=Restrict to pieces in Deck |
Contributor
There was a problem hiding this comment.
"Apply" is the word associated with Global Key Commands. "Restrict" could be confused with the "Restrict..." traits. Take a look at Editor.MassKey.deck_content. Something like Apply only to contents of Decks may be more explanatory and inline with the existing terminology. However this doesn't indicate to the user that the Global Key Command applies to all pieces on the map when unchecked. Naming is hard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #13018